github: restrict workflow permissions #6333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes all default permissions, and only adds needed permissions to the workflows that need it. - read contents: allows reading the repository, most workflows need this - write contents: allows to write to the repository. Needed to create releases - write pull-requests: allows to manipulate pull requests. Unfortunately this is needed to comment on PRs - read actions: allows reading the state of actions Signed-off-by: Pau Ruiz Safont <[email protected]>
|
The normal PR workflows are working and uploading artificats as usual |
|
What's missing to test: creating a release, deploy to pypi, push commits to docs repo. I think we'll have to bite the bullet here and act if they break with this change, although unlikely. |
lindig
approved these changes
Mar 3, 2025
edwintorok
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all default permissions, and only adds needed permissions to the workflows that need it.
Note that because all workflows remove all permissions at the top level the current default permissions don't take any effect.