xapi_vdi_helpers: actually write raw vdi when possible #6334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pau Ruiz Safont <[email protected]>
changlei-li
reviewed
Mar 3, 2025
| @@ -184,7 +184,7 @@ let get_pointer half = | |||
| (* Lay out a blank double-buffered redo log on the given block device. *) | |||
| (* May raise Unixext.Timeout exception *) | |||
| let initialise_redo_log block_dev_fd target_response_time = | |||
| ignore_int (Unixext.seek_to block_dev_fd 0) ; | |||
There was a problem hiding this comment.
Does this change make it more efficient, or just come out from code style?
There was a problem hiding this comment.
It might be more efficient since there's one closure (function) being called. But benefits are marginal, it's more about introducing the style to the codebase so we can stop calling ignore without using types
|
We are now replacing |
Which substitution is missing a type annotation? All of them are meant to be |
|
Sorry, was misreading this - it's now at the end |
lindig
approved these changes
Mar 3, 2025
lindig
reviewed
Mar 3, 2025
This way of using ignores doesn't need specialized functions and can be used with parametrized types (_ list) to avoid partial application. Signed-off-by: Pau Ruiz Safont <[email protected]>
A regression made the function every single time: 5ac7032 Signed-off-by: Pau Ruiz Safont <[email protected]>
psafont
force-pushed
the
private/paus/ign
branch
from
631516e to
4e88aba
Compare
changlei-li
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An
if ... then raise exn;was misread and make the code after impossible to execute, when that was not the intention.Remove all the ignore_ functions from stdext: a plain ignore with a type annotation can replace these. We should start using those for all ignores (there are too many of them, and can't be easily automated to do it in this PR)
Passes internal tests: 213465 (one failure due to the recent vlan + clustering issue)