Skip to content

Add window dimension cvars #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

randprint
Copy link
Contributor

add window dimensions to config.toml to make it easy to choose default window size at launch

@illusion0001
Copy link
Contributor

Nitpick: Add [UI] to commit name

@gibbed gibbed changed the title add window dimensions to config.toml to make it easy to choose default window size Add window dimension cvars Aug 28, 2019
@@ -29,6 +29,9 @@

DECLARE_bool(debug);

DEFINE_int32(window_height, 720, "Window height", "UI");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1280x720 hardcoded cvar defaults are not the way it should be handled, because that would block the addition of 480p and 1080p video output mode settings.

Copy link
Contributor Author

@randprint randprint Nov 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just for convenience to not have to resize the window every time I launch on a 4k (48") screen. I don't know if it's even still applicable that xenia just stretches to fill the window without respecting aspect ratio now that you added the safezones. It would be a nice QOL feature if you can think of a better way to do it. As well as if Xenia would remember window position because my hack in fix for that is even uglier so I don't have to drag the window across the screen every time I launch too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants