Add message box when emulator fails to load invalid or corrupted file. #2075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CookiePLMonster
suggested changes
Oct 13, 2022
Co-authored-by: Silent <[email protected]>
Co-authored-by: Silent <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements a message box when the user attempts to open an invalid or corrupt file format, either by dragging and dropping or by opening it through the file system.
Before, the emulator would just immediately terminate if this happened, which is something that should be avoided whenever possible because it's not particularly constructive or informative for the user. In this case it is completely avoidable, so it might as well be avoided.
With this pull request the emulator will no longer immediately crash, it will instead show a message box that actually tells the user what went wrong.
Xenia.Message.Box.mp4