-
Notifications
You must be signed in to change notification settings - Fork 91
[Feat] Setup function #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes! 👏
I just left a question, but it's all good.
|
||
private val lineApiClient: LineApiClient | ||
private val channelId: String | ||
private lateinit var channelId: String |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't need this variable right?
): LineAuthenticationConfig? { | ||
return createConfig( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can just use the shorter way (fun createLineAuthenticationConfig() = createConfig(...))
@@ -22,6 +23,7 @@ export default function () { | |||
|
|||
useEffect(() => { | |||
if (loaded) { | |||
Line.setup('2006826760') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it shouldn't be public, right? 👀
PR Title
🔄 Type of change:
✏️ Description: