Skip to content

[Feat] Setup function #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 4, 2025
Merged

[Feat] Setup function #138

merged 12 commits into from
Feb 4, 2025

Conversation

Joaguirrem
Copy link
Collaborator

PR Title

🔄 Type of change:

  • ✨Feature/chore
  • ♻️ Refactor
  • 🔧 Bugfixes

✏️ Description:

  • Create a setup function to initialize the native module.
  • Removes the channel ID string from Android resources.
  • Remove the Expo plugin.
  • Refactor JavaScript functions.
  • Improve comments and documentation.
  • Update dependencies.

@Joaguirrem Joaguirrem requested review from franbe7 and carozo February 4, 2025 20:18
Copy link
Contributor

@franbe7 franbe7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes! 👏
I just left a question, but it's all good.

@Joaguirrem Joaguirrem merged commit 8615364 into master Feb 4, 2025
@Joaguirrem Joaguirrem deleted the v4 branch February 4, 2025 21:05

private val lineApiClient: LineApiClient
private val channelId: String
private lateinit var channelId: String
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need this variable right?

Comment on lines +306 to +307
): LineAuthenticationConfig? {
return createConfig(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can just use the shorter way (fun createLineAuthenticationConfig() = createConfig(...))

@@ -22,6 +23,7 @@ export default function () {

useEffect(() => {
if (loaded) {
Line.setup('2006826760')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it shouldn't be public, right? 👀

@Joaguirrem Joaguirrem changed the title Setup function [Feat] Setup function Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants