Skip to content

remove _workCell in InputHandler. #5103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2024
Merged

Conversation

tisilent
Copy link
Contributor

@tisilent tisilent commented Jul 12, 2024

Trying to add 'no-unused-private-class-members' does not work. 😪

@tisilent tisilent changed the title remove _workCell. remove _workCell in InputHandler. Jul 12, 2024
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@Tyriar
Copy link
Member

Tyriar commented Jul 14, 2024

Is that's the only change needed to add that rule we should add it as a warning (ie. everything should work but no merging without it fixed).

@Tyriar Tyriar added this to the 5.6.0 milestone Jul 14, 2024
@Tyriar Tyriar merged commit 9d8bba7 into xtermjs:master Jul 14, 2024
12 checks passed
@Tyriar Tyriar modified the milestones: 5.6.0, 6.0.0 Jul 14, 2024
@tisilent tisilent deleted the remove-unread branch July 15, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants