Skip to content

XWIKI-22789: Ctrl + click does not work on links in the QuickSearch dropdown #4306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented Jun 19, 2025

Jira URL

https://jira.xwiki.org/browse/XWIKI-22789

Changes

Description

  • For memos with an url, we let the browser handle all the anchor logic and rely on native behaviours instead of hardcodding a degraded version of them.

Clarifications

  • For XWIKI-16140, we already made anchors the elements where it'd make sense. In this PR, we just need to get rid of some custom logic and rely on what the standards and browsers give us.

Screenshots & Video

Video demo

2025-06-19.17-52-21.mp4

We can see on this demo that the default behaviour is the same (just clicking on the link will move us to the new page).
However,

Executed Tests

Built the affected module with mvn clean install -f xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-webjar successfully and then used it on my local instance to make the manual test highlighted in the video above.

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • 17.4.X, 16.10.X (average dangerosity -- could break a very used feature, average scope -- it's on every page but only in a specific element)

…ropdown

* For memos with an url, we let the browser handle all the anchor logic and rely on native behaviours instead of hardcodding a degraded version of them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants