Skip to content

XWIKI-23335: The upload widget throws an error after uploading an attachment #4324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Farcasut
Copy link
Contributor

@Farcasut Farcasut commented Jun 25, 2025

Jira URL

https://jira.xwiki.org/browse/XWIKI-23335

Changes

Description

Updated the attachments.js to check for existence of the element before using it.

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • Might not be important enough.

…tachment

* Updated the attachments.js to check for existence of the element before using it
@Farcasut Farcasut changed the title XWIKI-23335: The upload widget throws and error after uploading an attachment XWIKI-23335: The upload widget throws an error after uploading an attachment Jun 25, 2025
@oanalavinia oanalavinia self-requested a review June 25, 2025 12:35
Copy link
Contributor

@oanalavinia oanalavinia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Did you also run the AttachmentIT tests?

@Farcasut
Copy link
Contributor Author

Looks good! Did you also run the AttachmentIT tests?

Yes, here is a screenshot:
image

Copy link
Contributor

@oanalavinia oanalavinia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

I'll merge this next week after the 17.5.0 release, to not affect the CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants