Skip to content

Fix false positives of rspec matchers #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix false positives of rspec matchers #42

wants to merge 1 commit into from

Conversation

jbockler
Copy link

When using the rspec matchers with a specific value, e.g. .with(42), there wasn't actually an expecatation set and thus it was always successfull even when the metric was actually updated with another value.

@jbockler
Fix false positives of rspec matchers
44d0a38 
When using the rspec matchers with a specific value,
e.g. `.with(42)`, there wasn't actually an expecatation
set and thus it was always successfull even when the
metric was actually updated with another value.
@jbockler jbockler force-pushed the fix-matchers-always-success branch from c51be45 to 44d0a38 Compare May 15, 2025 21:19
@jbockler
Copy link
Author

Hi @Envek,
could you please take a look into this issue? As a creator of a gem providing yabeda metrics this is a pretty big issue, as the test suite is pretty much useless due to this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jbockler