Quarkus: do all scans (not limited to security checks) #3324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rather than just calling
dictionary.scanForSecurityChecks()we now callelide.doScans()instead. This causes the built-in type converters to be registered, whereas they weren't before. Security checks are still also registered, as before.Motivation and Context
This solves the issue whereby the built in type converters were not being registered by the quarkus extension. For example, attempting to use OffsetDateTime as a field type resulted in a failure at runtime due to the type being unknown.
How Has This Been Tested?
A simple new, passing test is added that filters on a OffsetDateTime field. I have confirmed the test failed before the change was implemented.
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.