[NBS] shadow disk release devices after destruction #3622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thank you for contributing! |
komarevtsev-d
added
blockstore
github-actions
bot
removed
the
ok-to-test
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 0466eb5.
🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 0466eb5.
|
komarevtsev-d
requested changes
Jun 5, 2025
cloud/blockstore/libs/storage/disk_agent/model/device_client.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/volume/volume_actor_checkpoint.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/volume/volume_actor_checkpoint.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/volume/volume_actor_checkpoint.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/volume/volume_actor_checkpoint.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/volume/volume_actor_checkpoint.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/volume/volume_actor_checkpoint.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/volume/volume_actor_checkpoint.cpp
Outdated
Show resolved
Hide resolved
komarevtsev-d
requested changes
Jun 16, 2025
cloud/blockstore/libs/storage/volume/volume_actor_checkpoint.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/volume/volume_actor_checkpoint.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/volume/volume_actor_checkpoint.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/volume/volume_actor_checkpoint.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/volume/volume_actor_checkpoint.cpp
Outdated
Show resolved
Hide resolved
komarevtsev-d
requested changes
Jun 18, 2025
cloud/blockstore/libs/storage/volume/volume_actor_checkpoint.cpp
Outdated
Show resolved
Hide resolved
| LOG_ERROR( | ||
| ctx, | ||
| TBlockStoreComponents::VOLUME, | ||
| "Error occured when try to release shadow disk %s for clientId: %s." |
There was a problem hiding this comment.
Failed to release shadow disk %s for client %s. Error: %s
komarevtsev-d
previously approved these changes
Jun 19, 2025
sharpeye
reviewed
Jun 19, 2025
Comment on lines
211
to
216
| if (const TCheckpointRequest* checkpointRequest = | ||
| CheckpointRequests.FindPtr(CheckpointRequestInProgress)) | ||
| CheckpointRequests.FindPtr(CheckpointRequestInProgress); | ||
| checkpointRequest != nullptr && | ||
| checkpointRequest->CheckpointId == checkpointId) | ||
| { | ||
| if (checkpointRequest->ReqType == ECheckpointRequestType::Delete || |
There was a problem hiding this comment.
Можно во внутренний if положить:
if (const TCheckpointRequest* checkpointRequest =
CheckpointRequests.FindPtr(CheckpointRequestInProgress))
{
if (checkpointRequest->CheckpointId == checkpointId &&
(checkpointRequest->ReqType == ECheckpointRequestType::Delete ||
checkpointRequest->ReqType == ECheckpointRequestType::DeleteData))
{
return false;
}
}| const auto releaseSessionKind = | ||
| static_cast<EReleaseSessionKind>(ev->Cookie); | ||
|
|
||
| if (record.HasError()) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Этот pull request решает проблему: [NBS] Shadow disk does not release its devices after destruction #3097.
Shadow disk не освобождал свои девайсы после удаления чекпоинта,
теперь эта проблема решена.