Skip to content

issue-3699: allow creation and unlinking of the parentless files #3698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

debnatkh
Copy link
Collaborator

@debnatkh debnatkh commented Jun 17, 2025

@debnatkh debnatkh added the filestore Add this label to run only cloud/filestore build and tests on PR label Jun 17, 2025
@debnatkh debnatkh force-pushed the users/debnatkh/parentless branch from 5e7ac77 to 4116f97 Compare June 18, 2025 08:22
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 4116f97.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2785 2785 0 0 0 0

@debnatkh debnatkh changed the title draft: allow parentless files issue-3699: allow creation and unlinking of the parentless files Jun 18, 2025
@debnatkh debnatkh marked this pull request as ready for review June 18, 2025 11:11
@debnatkh debnatkh requested a review from SvartMetal June 18, 2025 11:39
@@ -142,7 +142,8 @@ NProto::TError TIndexTabletState::UnlinkNode(
const TString& name,
const IIndexTabletDatabase::TNode& node,
ui64 minCommitId,
ui64 maxCommitId)
ui64 maxCommitId,
bool disregardNodeRef)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doNotRemoveNodeRef?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

инвертировал логику, сделал removeNodeRef

@debnatkh debnatkh requested a review from SvartMetal June 24, 2025 15:45
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit b4cfb0d.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2785 2785 0 0 0 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filestore Add this label to run only cloud/filestore build and tests on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants