Fix behavior for controller actions with union types #20352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
! fix yii\web\Controller::bindActionParams behaviour for union types o some refactoring in the process
o cleanup, changelog
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20352 +/- ##
============================================
- Coverage 63.44% 63.38% -0.06%
- Complexity 11445 11468 +23
============================================
Files 431 431
Lines 37207 37251 +44
============================================
+ Hits 23606 23612 +6
- Misses 13601 13639 +38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Does |
samdark
reviewed
Apr 13, 2025
| if ($type instanceof \ReflectionNamedType) { | ||
| [$result, $isValid] = $this->filterSingleTypeActionParam($params[$name], $type); | ||
| $params[$name] = $result; | ||
| } elseif (class_exists('\ReflectionUnionType') && $type instanceof \ReflectionUnionType) { |
There was a problem hiding this comment.
I don't think class_exists is needed here.
|
Would you please measure performance impact w/ phpbench if possible? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the behaviour for
yii\web\Controller::bindActionParamswhen a function parameter has a union type.In effect, this fixes two issues:
string|int), if the parameter value is a string containing a numeric value (such as'1'), the result will be the numeric value ((int)1here) rather than the string.int|array), if the parameter value is an array, the controller no longer throws aBadRequestHttpException, fixing "Bad request" for array parameter with union type #20351.