Template registration, first implementation #1025
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1021 and the linked gist.
Here's a first drop for template registration, including full tests, user guide documentation, and API docs.
@ericf and I were discussing a possible addition to the
Y.Template.register
API, where it would also accept a hash of template names to template functions. For example:I started implementing something like this, but I wasn't sure what
Y.Template.register(templateHash)
would return. The currentY.Template.register(templateName, template)
returns the revived template to maintain compatibility with therevive()
API.Pinging @caridy also for review.