Exclude base image validation in kube-system #9174
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkeloscar
added
the
bugfix
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
mikkeloscar
force-pushed
the
exclude-kube-system-base-image
branch
from
e22b422 to
fb9bd2a
Compare
linki
reviewed
Apr 8, 2025
| @@ -606,6 +606,7 @@ kubelet_image_gc_low_threshold: 40 | |||
| {{if eq .Cluster.Environment "production"}} | |||
| teapot_admission_controller_validate_application_label: "true" | |||
| teapot_admission_controller_validate_base_images: "true" | |||
| teapot_admission_controller_validate_base_images_namespaces: "^kube-system$" | |||
There was a problem hiding this comment.
Doesn't this enable the base image check only in kube-system this way?
There was a problem hiding this comment.
I don't think we did base image checks in kube-system before. Looks like it's excluded here (as a protected namespace): https://github.bus.zalan.do/teapot/admission-controller/blob/6de653566e2674a442397f983a895829274a2711/pkg/podfactory/resource_validator.go#L194
There was a problem hiding this comment.
Yeah, I realized this is at least wrong.
Will try to replicate the prod issue in a pet cluster to better think about a solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid a circular dependency as explained in #9092 exclude the base image validation in kube-system,
This check is disabled in e2e making it different from production. It's tricky to enable in e2e as we have many e2e images that would not pass.