You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe what should be investigated or refactored
We have a lot of code that uses interactive functions to get user input in our library functions. This requires the code to be aware of it is being used in a context where user input could be fetched. Making the code questionably thread safe in these situations if it were to be called in parallel.
It would be best to move any use of code related to user input to the cmd package. In the future any code that is being exported for library use should not concert itself with user input.
Describe what should be investigated or refactored
We have a lot of code that uses interactive functions to get user input in our library functions. This requires the code to be aware of it is being used in a context where user input could be fetched. Making the code questionably thread safe in these situations if it were to be called in parallel.
It would be best to move any use of code related to user input to the cmd package. In the future any code that is being exported for library use should not concert itself with user input.
Links to any relevant code
zarf/src/pkg/packager/creator/template.go
Lines 35 to 37 in 8100c69
zarf/src/pkg/packager/filters/deploy.go
Lines 138 to 141 in 8100c69
zarf/src/pkg/packager/filters/deploy.go
Lines 170 to 173 in 8100c69
Additional context
N/A
The text was updated successfully, but these errors were encountered: