Skip to content

fix(release): remaining environment variables swap #3809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 15, 2025
Merged

fix(release): remaining environment variables swap #3809

merged 2 commits into from
May 15, 2025

Conversation

brandtkeller
Copy link
Member

Description

Fix the release failing due to ARCHIVER_VERSION needing to be ARCHIVES_VERSION

Checklist before merging

@brandtkeller brandtkeller requested review from a team as code owners May 15, 2025 19:15
@netlify Netlify
Copy link

netlify bot commented May 15, 2025 •
edited
Loading

✅ Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit 80dca8e
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/68263fd9031b8a000842b6a8
😎 Deploy Preview https://deploy-preview-3809--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@brandtkeller brandtkeller self-assigned this May 15, 2025
@codecov Codecov
Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mkcp
mkcp approved these changes May 15, 2025
View reviewed changes
Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandtkeller brandtkeller enabled auto-merge May 15, 2025 19:38
@brandtkeller brandtkeller added this pull request to the merge queue May 15, 2025
Merged via the queue into main with commit f1add04 May 15, 2025
39 checks passed
@brandtkeller brandtkeller deleted the fix_release_flags branch May 15, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkcp mkcp mkcp approved these changes

Assignees

@brandtkeller brandtkeller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandtkeller @mkcp