Implement regex search as SearchToggleOption #4098
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianlzt
force-pushed
the
add-regex-search
branch
2 times, most recently
from
9f3c875 to
f76a1d3
Compare
* Add a new field `regex_search` to the `SearchResult` struct in `zellij-server/src/panes/search.rs`. * Implement regex search functionality in the `search_row` method of `SearchResult` in `zellij-server/src/panes/search.rs`. * Update the `check_if_haystack_char_matches_needle` method to handle regex search in `zellij-server/src/panes/search.rs`. * Add a new method `toggle_search_regex` to the `Grid` struct in `zellij-server/src/panes/terminal_pane.rs` to toggle regex search. * Update the `set_search_string` method in `Grid` to handle regex search if `regex_search` is enabled in `zellij-server/src/panes/terminal_pane.rs`. * Add unit tests for regex search functionality in `search_row` method of `SearchResult` in `zellij-server/src/panes/unit/search_in_pane_tests.rs`. * Add unit tests for `toggle_search_regex` method in `Grid` struct in `zellij-server/src/panes/unit/search_in_pane_tests.rs`.
adrianlzt
force-pushed
the
add-regex-search
branch
from
f76a1d3 to
5af044e
Compare
|
This PR is still incomplete (some tests and highlighting errors). zellij-regex.mp4Closes #4097 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement regex search functionality as a new SearchToggleOption.
regex_searchto theSearchResultstruct inzellij-server/src/panes/search.rs.search_rowmethod ofSearchResultinzellij-server/src/panes/search.rs.check_if_haystack_char_matches_needlemethod to handle regex search inzellij-server/src/panes/search.rs.toggle_search_regexto theGridstruct inzellij-server/src/panes/terminal_pane.rsto toggle regex search.set_search_stringmethod inGridto handle regex search ifregex_searchis enabled inzellij-server/src/panes/terminal_pane.rs.search_rowmethod ofSearchResultinzellij-server/src/panes/unit/search_in_pane_tests.rs.toggle_search_regexmethod inGridstruct inzellij-server/src/panes/unit/search_in_pane_tests.rs.