-
Notifications
You must be signed in to change notification settings - Fork 121
Metadata\Source\Factory throws specific exception #170
base: develop
Are you sure you want to change the base?
Metadata\Source\Factory throws specific exception #170
Conversation
Your changes have failed the coding standards check. Please refer to CONTRIBUTING.md for details on how to run php-cs-fixer on your changes to ensure they conform. |
Done |
Would it be better to rename |
@Naktibalda I'm planning to merge this PR for zend-db 3.0.0. It's ok using InvalidArgumentException as you did in the PR. We don't need a specific UnknownPlatformException becuase now we have a better namespace. |
I changed the base branch, but I don't understand what you mean with "a better namespace", do I need to change anything in the code? |
This repository has been moved to laminas/laminas-db. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:
|
This repository has been closed and moved to laminas/laminas-db; a new issue has been opened at laminas/laminas-db#95. |
Metadata\Source\Factory throws specific exception when the platform is not supported.
It will help to catch this specific exception in zf-apigility-admin,
matching exception by text is too fragile.
https://github.com/zfcampus/zf-apigility-admin/pull/365/files