Fix #295: handle empty array as datasource at AbstractResultSet::initialize() at php 7.2

[samsonasik]

Provide a narrative description of what you are trying to accomplish:

• Are you fixing a bug?
  • Detail how the bug is invoked currently.
    is count() on datasource whenever datasource is empty array
  • Detail the original, incorrect behavior.
    when datasource is empty array, it got error: "count(): Parameter must be an array or an object that implements Countable"
  • Detail the new, expected behavior.
    check the current() method, when it return false, set the count itself as 0.
  • Base your feature on the master branch, and submit against that branch.
  • Add a regression test that demonstrates the bug, and proves the fix.
  • Add a CHANGELOG.md entry for the fix.

Fix #295

[froschdesign]

#303 is the PR but #295 is the bug report. You should use #295.

[samsonasik]

done ;), I've updated the reference link to use #295

[sfortop]

@froschdesign

#303 is the PR but #295 is the bug report. You should use #295.

Why?
All changelog use PR link not bug report.

[mvoelker]

Solves the problem with my code and unit tests with php 7.2.

[samsonasik]

is there any chance to get it merged? Thank you.

[adear11]

Just wondering if this will be merged into a release any time soon. I have an Apigility API that is using zend-db. This is blocking me from upgrading it to php 7.2.

[michalbundyra]

LGTM 👍

[samsonasik]

rebased.

[jhse-labs]

It's good to use zend-db now with PHP 7.2!
Unfortunately this patch changed the return type behaviour of AbstractResultSet->current().
When the result set is empty (array has zero elements), the current() method returned null prior this bugfix. But now it returns an empty array (array() or []) in that case.

I noticed this as the persistence layer in my application stopped working in some cases. So iIf anyone else runs into similar problems, maybe this entry helps!

[samsonasik]

@rzjack I created test at #313 and the AbstractResultSet::current() still return null ( correct ). I can't reproduce issue with the test at AbstractResultSet::current() with initialize with empty array. Please provide unit test to prove the changed behavior.