This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Allow usage with zend-hydrator v3 #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updates `require-dev` constrainte for zend-hydrator to also allow v3 releases. - Updates travis configuration to list zend-hydrator as a legacy dependency for pre-7.2 versions.
One major change in zend-hydrator v3 is that we have added "Hydrator" suffixes to all hydrators. The original versions still exist, and can be used, but emit deprecation notices. What this change does is version detection: it checks for the new class name, and uses that as the default if available, falling back to the old class names. This prevents the deprecation notices, while proving that both versions work fine with this component.
Ocramius
approved these changes
Dec 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zend-hydrator v3 is backwards compatible from a consumer standpoint. However, when using the v2 hydrator classes under v3, you will receive deprecation notices. This patch does the following to mitigate that:
HydratingResultSetwill compose either anArraySerializableorArraySerializableHydratorinstance, based on version detection of zend-hydrator, when no hydrator is provided to the constructor.Additionally, the travis configuration was updated to list zend-hydrator as a legacy dependency for locked versions below PHP 7.2, allowing them to downgrade successfully.