Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Rely on abstractions instead of concretions #377

Merged
merged 1 commit into from
Dec 31, 2019
Merged

Rely on abstractions instead of concretions #377

merged 1 commit into from
Dec 31, 2019

Conversation

paulovitorbal
Copy link
Contributor

I changed the class to look for the AdapterInterface instead of the Adapter class itself

Provide a narrative description of what you are trying to accomplish:

  • Are you fixing a bug?

    • Detail how the bug is invoked currently.
    • Detail the original, incorrect behavior.
    • Detail the new, expected behavior.
    • Base your feature on the master branch, and submit against that branch.
    • Add a regression test that demonstrates the bug, and proves the fix.
    • Add a CHANGELOG.md entry for the fix.
  • Are you creating a new feature?

    • Why is the new feature needed? What purpose does it serve?
    • How will users use the new feature?
    • Base your feature on the develop branch, and submit against that branch.
    • Add only one feature per pull request; split multiple features over multiple pull requests
    • Add tests for the new feature.
    • Add documentation for the new feature.
    • Add a CHANGELOG.md entry for the new feature.
  • Is this related to quality assurance?
    This change will make the class rely on the abstraction (interface) instead of the concretion (the class itself)

  • Is this related to documentation?

I changed the class to look for the AdapterInterface instead of the Adapter class itself
Copy link
Member

@michalbundyra michalbundyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@michalbundyra michalbundyra added this to the 2.10.1 milestone Dec 31, 2019
@michalbundyra
Copy link
Member

Thanks, @paulovitorbal!

michalbundyra added a commit that referenced this pull request Dec 31, 2019
michalbundyra added a commit that referenced this pull request Dec 31, 2019
michalbundyra added a commit that referenced this pull request Dec 31, 2019
@michalbundyra michalbundyra merged commit 6a52b12 into zendframework:master Dec 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants