This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Revert usage of ROUTE_MIDDLEWARE constant in ApplicationFactory #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…service' into release-3.0.0" This reverts commit 5f280f2, reversing changes made to bf4a4f8. The reversion is due to the fact that @webimpress has discovered that all supported containers resolve aliases to the target service BEFORE determining if the service has already been created. As such, pulling a service by its alias will retrieve the same instance as pulling it by its canonical name. As such, we can use the canonical name in the `ApplicationFactory` when retrieving the routing middleware for use with the `Application`. Conflicts: CHANGELOG.md
weierophinney
added a commit
that referenced
this pull request
Feb 15, 2018
weierophinney
added a commit
that referenced
this pull request
Feb 15, 2018
weierophinney
added a commit
to weierophinney/zend-expressive-skeleton
that referenced
this pull request
Feb 15, 2018
This patch follows on zendframework/zend-expressive#559, and modifies the pipeline to directly refer to the `PathBasedRoutingMiddleware` instead of using the `ROUTE_MIDDLEWARE` constant. It's better and faster to use the canonical name, and the old name (to which the constant resolves) is an alias for purposes of aiding those upgrading from v2; since aliases resolve to the same instance as the canonical service, this remains backwards compatible.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #556.
The reversion is due to the fact that @webimpress has discovered that all supported containers resolve aliases to the target service BEFORE determining if the service has already been created. As such, pulling a service by its alias will retrieve the same instance as pulling it by its canonical name.
As such, we can use the canonical name in the
ApplicationFactorywhen retrieving the routing middleware for use with theApplication.