picolibc: Disable exceptions for picolibc libstdc++ #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `CT_LIBC_PICOLIBC_GCC_LIBSTDCXX_TARGET_CXXFLAGS` config option and set it by default to '-fno-exceptions'. Signed-off-by: Adrian Gielniewski <[email protected]>
Damian-Nordic
approved these changes
Feb 27, 2025
maciejbaczmanski
approved these changes
Feb 27, 2025
| config LIBC_PICOLIBC_GCC_LIBSTDCXX_TARGET_CXXFLAGS | ||
| string | ||
| prompt "Target CXXFLAGS for libstdc++ picolibc variant" | ||
| default "-fno-exceptions" |
There was a problem hiding this comment.
Just a thought, would it make sense to use this default for ARM thumb only? I can see some samples in Zephyr that enable CPP_EXCEPTIONS so would probably be good to be able to still run them on some qemu targets.
There was a problem hiding this comment.
But do they use picolibc? It's the same as for the newlib-nano: https://github.com/zephyrproject-rtos/crosstool-ng/blob/zephyr-crosstool-ng-1.25.0/config/comp_libs/newlib-nano.in#L25
There was a problem hiding this comment.
OK, I found it. I think it would be the best to have the same configuration for all targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
CT_LIBC_PICOLIBC_GCC_LIBSTDCXX_TARGET_CXXFLAGSconfig option and set it by default to-fno-exceptions.