Skip to content

No support for current Zephyr version #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dgloeck opened this issue Feb 6, 2019 · 1 comment
Closed

No support for current Zephyr version #3

dgloeck opened this issue Feb 6, 2019 · 1 comment

Comments

@dgloeck
Copy link

dgloeck commented Feb 6, 2019

Commit zephyrproject-rtos/zephyr@1b2ca67 raised the version inside the .openocd_dbg section from 0 to 1. The code in this repository still expects the version to be 0.
@dgloeck dgloeck mentioned this issue Feb 16, 2019
Closed
dgloeck added a commit to dgloeck/openocd that referenced this issue Feb 17, 2019
@dgloeck
rtos/Zephyr: support recent Zephyr versions
b8d6236 
Fixes zephyrproject-rtos#3

Signed-off-by: Daniel Glöckner <[email protected]>
galak pushed a commit to dgloeck/openocd that referenced this issue Feb 18, 2019
@dgloeck @galak
rtos/Zephyr: support recent Zephyr versions
8be1f29 
Fixes zephyrproject-rtos#3

Signed-off-by: Daniel Glöckner <[email protected]>
dgloeck added a commit to dgloeck/openocd that referenced this issue Feb 25, 2019
@dgloeck
rtos/Zephyr: support recent Zephyr versions
b57c871 
The current version reported by Zephyr in the offsets array is 1.
It is compatible to version 0 but offers a few more values in the
array. zephyrproject-rtos/zephyr#13461 adds a separate symbol to
hold the size of the array, so that future compatible additions
do not require the version number to be incremented.

Fixes zephyrproject-rtos#3

Signed-off-by: Daniel Glöckner <[email protected]>
galak pushed a commit that referenced this issue Feb 27, 2019
@dgloeck @galak
rtos/Zephyr: support recent Zephyr versions
92b758a 
The current version reported by Zephyr in the offsets array is 1.
It is compatible to version 0 but offers a few more values in the
array. zephyrproject-rtos/zephyr#13461 adds a separate symbol to
hold the size of the array, so that future compatible additions
do not require the version number to be incremented.

Fixes #3

Signed-off-by: Daniel Glöckner <[email protected]>
galak pushed a commit that referenced this issue Feb 27, 2019
@dgloeck @galak
rtos/Zephyr: support recent Zephyr versions
85139aa 
The current version reported by Zephyr in the offsets array is 1.
It is compatible to version 0 but offers a few more values in the
array. zephyrproject-rtos/zephyr#13461 adds a separate symbol to
hold the size of the array, so that future compatible additions
do not require the version number to be incremented.

Fixes #3

Signed-off-by: Daniel Glöckner <[email protected]>
@galak
Copy link
Contributor

galak commented Feb 28, 2019

Fixed by PR #5

@galak galak closed this as completed Feb 28, 2019
galak pushed a commit to galak/openocd that referenced this issue Jul 3, 2019
@dgloeck @galak
rtos/Zephyr: support recent Zephyr versions
8376144 
The current version reported by Zephyr in the offsets array is 1.
It is compatible to version 0 but offers a few more values in the
array. zephyrproject-rtos/zephyr#13461 adds a separate symbol to
hold the size of the array, so that future compatible additions
do not require the version number to be incremented.

Fixes zephyrproject-rtos#3

Signed-off-by: Daniel Glöckner <[email protected]>
galak pushed a commit to galak/openocd that referenced this issue Oct 3, 2019
@dgloeck @galak
rtos/Zephyr: support recent Zephyr versions
dafdd05 
The current version reported by Zephyr in the offsets array is 1.
It is compatible to version 0 but offers a few more values in the
array. zephyrproject-rtos/zephyr#13461 adds a separate symbol to
hold the size of the array, so that future compatible additions
do not require the version number to be incremented.

Fixes zephyrproject-rtos#3

Signed-off-by: Daniel Glöckner <[email protected]>
galak pushed a commit that referenced this issue Oct 3, 2019
@dgloeck @galak
rtos/Zephyr: support recent Zephyr versions
40038cb 
The current version reported by Zephyr in the offsets array is 1.
It is compatible to version 0 but offers a few more values in the
array. zephyrproject-rtos/zephyr#13461 adds a separate symbol to
hold the size of the array, so that future compatible additions
do not require the version number to be incremented.

Fixes #3

Signed-off-by: Daniel Glöckner <[email protected]>
abrodkin referenced this issue in EvgeniiDidin/openocd-1 Nov 26, 2019
@EvgeniiDidin
tcl/target: Enable L2 cache support for HSDK board
3fe50ae 
Signed-off-by: Evgeniy Didin <[email protected]>
galak pushed a commit that referenced this issue Jan 15, 2020
@dgloeck @galak
rtos/Zephyr: support recent Zephyr versions
57817a4 
The current version reported by Zephyr in the offsets array is 1.
It is compatible to version 0 but offers a few more values in the
array. zephyrproject-rtos/zephyr#13461 adds a separate symbol to
hold the size of the array, so that future compatible additions
do not require the version number to be incremented.

Fixes #3

Signed-off-by: Daniel Glöckner <[email protected]>
galak pushed a commit that referenced this issue Jan 15, 2020
@dgloeck @galak
rtos/Zephyr: support recent Zephyr versions
8531a84 
The current version reported by Zephyr in the offsets array is 1.
It is compatible to version 0 but offers a few more values in the
array. zephyrproject-rtos/zephyr#13461 adds a separate symbol to
hold the size of the array, so that future compatible additions
do not require the version number to be incremented.

Fixes #3

Signed-off-by: Daniel Glöckner <[email protected]>
galak pushed a commit that referenced this issue Jan 17, 2020
@dgloeck @galak
rtos/Zephyr: support recent Zephyr versions
885e76f 
The current version reported by Zephyr in the offsets array is 1.
It is compatible to version 0 but offers a few more values in the
array. zephyrproject-rtos/zephyr#13461 adds a separate symbol to
hold the size of the array, so that future compatible additions
do not require the version number to be incremented.

Fixes #3

Signed-off-by: Daniel Glöckner <[email protected]>
galak pushed a commit to galak/openocd that referenced this issue Jul 22, 2020
@dgloeck @galak
rtos/Zephyr: support recent Zephyr versions
beaa706 
The current version reported by Zephyr in the offsets array is 1.
It is compatible to version 0 but offers a few more values in the
array. zephyrproject-rtos/zephyr#13461 adds a separate symbol to
hold the size of the array, so that future compatible additions
do not require the version number to be incremented.

Fixes zephyrproject-rtos#3

Signed-off-by: Daniel Glöckner <[email protected]>
galak pushed a commit to galak/openocd that referenced this issue Jul 22, 2020
@dgloeck @galak
rtos/Zephyr: support recent Zephyr versions
beec309 
The current version reported by Zephyr in the offsets array is 1.
It is compatible to version 0 but offers a few more values in the
array. zephyrproject-rtos/zephyr#13461 adds a separate symbol to
hold the size of the array, so that future compatible additions
do not require the version number to be incremented.

Fixes zephyrproject-rtos#3

Signed-off-by: Daniel Glöckner <[email protected]>
galak pushed a commit to galak/openocd that referenced this issue Aug 7, 2020
@dgloeck @galak
rtos/Zephyr: support recent Zephyr versions
84162ab 
The current version reported by Zephyr in the offsets array is 1.
It is compatible to version 0 but offers a few more values in the
array. zephyrproject-rtos/zephyr#13461 adds a separate symbol to
hold the size of the array, so that future compatible additions
do not require the version number to be incremented.

Fixes zephyrproject-rtos#3

Signed-off-by: Daniel Glöckner <[email protected]>
galak pushed a commit that referenced this issue Aug 7, 2020
@dgloeck @galak
rtos/Zephyr: support recent Zephyr versions
08e2cbc 
The current version reported by Zephyr in the offsets array is 1.
It is compatible to version 0 but offers a few more values in the
array. zephyrproject-rtos/zephyr#13461 adds a separate symbol to
hold the size of the array, so that future compatible additions
do not require the version number to be incremented.

Fixes #3

Signed-off-by: Daniel Glöckner <[email protected]>
M1cha pushed a commit to M1cha/openocd that referenced this issue Apr 26, 2021
@dgloeck @M1cha
rtos/Zephyr: support recent Zephyr versions
d5f0f1a 
The current version reported by Zephyr in the offsets array is 1.
It is compatible to version 0 but offers a few more values in the
array. zephyrproject-rtos/zephyr#13461 adds a separate symbol to
hold the size of the array, so that future compatible additions
do not require the version number to be incremented.

Fixes zephyrproject-rtos#3

Signed-off-by: Daniel Glöckner <[email protected]>
abrodkin added a commit to abrodkin/openocd that referenced this issue Nov 10, 2021
@abrodkin
target/arc: implement dummy checksum_memory()
a658834 
In zephyrproject-rtos/zephyr#35284 it was
found that use of "verify_image" command for ARC boards lead to
OpenOCD segfault:
--------------------------->8--------------------------
 Program received signal SIGSEGV, Segmentation fault.
 0x0000000000000000 in ?? ()
 (gdb) bt
 #0  0x0000000000000000 in ?? ()
 zephyrproject-rtos#1  0x0000000000455e27 in target_checksum_memory (target=target@entry=0xa52450, address=2415919104, size=19952, crc=crc@entry=0x7fffffffcf64) at src/target/target.c:2522
 zephyrproject-rtos#2  0x0000000000456066 in handle_verify_image_command_internal (cmd=0x7fffffffd040, verify=IMAGE_VERIFY) at src/target/target.c:3846
 zephyrproject-rtos#3  0x000000000047e4ca in run_command (num_words=2, words=0xa80800, c=0x9f3ea0, context=0x9a7010) at src/helper/command.c:582
 zephyrproject-rtos#4  exec_command (argv=0x7fffffffd140, argc=<optimized out>, c=0x9f3ea0, cmd_ctx=0x9a7010, interp=0x9a7070) at src/helper/command.c:950
 zephyrproject-rtos#5  jim_command_dispatch (interp=0x9a7070, argc=<optimized out>, argv=0x7fffffffd140) at src/helper/command.c:1001
 zephyrproject-rtos#6  0x00000000005b839a in JimInvokeCommand (interp=interp@entry=0x9a7070, objc=objc@entry=2, objv=objv@entry=0x7fffffffd140) at jim.c:10514
 zephyrproject-rtos#7  0x00000000005b8fbc in Jim_EvalObj (interp=interp@entry=0x9a7070, scriptObjPtr=scriptObjPtr@entry=0x9e96d0) at jim.c:11006
 zephyrproject-rtos#8  0x00000000005bb12b in Jim_EvalSource (interp=interp@entry=0x9a7070, filename=filename@entry=0x0, lineno=lineno@entry=0,
     script=script@entry=0x9e0db0 "verify_image build/zephyr/zephyr.elf") at jim.c:11298
 zephyrproject-rtos#9  0x000000000047df5f in command_run_line (context=context@entry=0x9a7010, line=0x9e0db0 "verify_image build/zephyr/zephyr.elf") at src/helper/command.c:626
 zephyrproject-rtos#10 0x000000000047f6b8 in parse_config_file (cmd_ctx=cmd_ctx@entry=0x9a7010) at src/helper/configuration.c:136
 zephyrproject-rtos#11 0x00000000004053ae in openocd_thread (cmd_ctx=0x9a7010, argv=0x7fffffffd378, argc=18) at src/openocd.c:296
 zephyrproject-rtos#12 openocd_main (argc=18, argv=0x7fffffffd378) at src/openocd.c:356
 zephyrproject-rtos#13 0x00007ffff710d505 in __libc_start_main () from /lib64/libc.so.6
 zephyrproject-rtos#14 0x0000000000404e9e in _start ()
--------------------------->8--------------------------

That happens because we used to have ".checksum_memory" undefined
for ARC. And it was undefined on purpose as we never got to implement
a target-executed applet for CRC calculation.

But there seems to be a work-around of using real memory read back
via JTAG. And for that we just need to return anything != ERROR_OK
from ".checksum_memory()" callback. Which we do here.

Now image verification works for ARC as well!

Signed-off-by: Alexey Brodkin <[email protected]>
galak pushed a commit that referenced this issue Nov 10, 2021
@abrodkin @galak
target/arc: implement dummy checksum_memory()
7e3dbbb 
In zephyrproject-rtos/zephyr#35284 it was
found that use of "verify_image" command for ARC boards lead to
OpenOCD segfault:
--------------------------->8--------------------------
 Program received signal SIGSEGV, Segmentation fault.
 0x0000000000000000 in ?? ()
 (gdb) bt
 #0  0x0000000000000000 in ?? ()
 #1  0x0000000000455e27 in target_checksum_memory (target=target@entry=0xa52450, address=2415919104, size=19952, crc=crc@entry=0x7fffffffcf64) at src/target/target.c:2522
 #2  0x0000000000456066 in handle_verify_image_command_internal (cmd=0x7fffffffd040, verify=IMAGE_VERIFY) at src/target/target.c:3846
 #3  0x000000000047e4ca in run_command (num_words=2, words=0xa80800, c=0x9f3ea0, context=0x9a7010) at src/helper/command.c:582
 #4  exec_command (argv=0x7fffffffd140, argc=<optimized out>, c=0x9f3ea0, cmd_ctx=0x9a7010, interp=0x9a7070) at src/helper/command.c:950
 #5  jim_command_dispatch (interp=0x9a7070, argc=<optimized out>, argv=0x7fffffffd140) at src/helper/command.c:1001
 #6  0x00000000005b839a in JimInvokeCommand (interp=interp@entry=0x9a7070, objc=objc@entry=2, objv=objv@entry=0x7fffffffd140) at jim.c:10514
 #7  0x00000000005b8fbc in Jim_EvalObj (interp=interp@entry=0x9a7070, scriptObjPtr=scriptObjPtr@entry=0x9e96d0) at jim.c:11006
 #8  0x00000000005bb12b in Jim_EvalSource (interp=interp@entry=0x9a7070, filename=filename@entry=0x0, lineno=lineno@entry=0,
     script=script@entry=0x9e0db0 "verify_image build/zephyr/zephyr.elf") at jim.c:11298
 #9  0x000000000047df5f in command_run_line (context=context@entry=0x9a7010, line=0x9e0db0 "verify_image build/zephyr/zephyr.elf") at src/helper/command.c:626
 #10 0x000000000047f6b8 in parse_config_file (cmd_ctx=cmd_ctx@entry=0x9a7010) at src/helper/configuration.c:136
 #11 0x00000000004053ae in openocd_thread (cmd_ctx=0x9a7010, argv=0x7fffffffd378, argc=18) at src/openocd.c:296
 #12 openocd_main (argc=18, argv=0x7fffffffd378) at src/openocd.c:356
 #13 0x00007ffff710d505 in __libc_start_main () from /lib64/libc.so.6
 #14 0x0000000000404e9e in _start ()
--------------------------->8--------------------------

That happens because we used to have ".checksum_memory" undefined
for ARC. And it was undefined on purpose as we never got to implement
a target-executed applet for CRC calculation.

But there seems to be a work-around of using real memory read back
via JTAG. And for that we just need to return anything != ERROR_OK
from ".checksum_memory()" callback. Which we do here.

Now image verification works for ARC as well!

Signed-off-by: Alexey Brodkin <[email protected]>
aaillet pushed a commit to iotbzh/openocd that referenced this issue May 9, 2022
@abrodkin @aaillet
target/arc: implement dummy checksum_memory()
7a204cb 
In zephyrproject-rtos/zephyr#35284 it was
found that use of "verify_image" command for ARC boards lead to
OpenOCD segfault:
--------------------------->8--------------------------
 Program received signal SIGSEGV, Segmentation fault.
 0x0000000000000000 in ?? ()
 (gdb) bt
 #0  0x0000000000000000 in ?? ()
 zephyrproject-rtos#1  0x0000000000455e27 in target_checksum_memory (target=target@entry=0xa52450, address=2415919104, size=19952, crc=crc@entry=0x7fffffffcf64) at src/target/target.c:2522
 zephyrproject-rtos#2  0x0000000000456066 in handle_verify_image_command_internal (cmd=0x7fffffffd040, verify=IMAGE_VERIFY) at src/target/target.c:3846
 zephyrproject-rtos#3  0x000000000047e4ca in run_command (num_words=2, words=0xa80800, c=0x9f3ea0, context=0x9a7010) at src/helper/command.c:582
 zephyrproject-rtos#4  exec_command (argv=0x7fffffffd140, argc=<optimized out>, c=0x9f3ea0, cmd_ctx=0x9a7010, interp=0x9a7070) at src/helper/command.c:950
 zephyrproject-rtos#5  jim_command_dispatch (interp=0x9a7070, argc=<optimized out>, argv=0x7fffffffd140) at src/helper/command.c:1001
 zephyrproject-rtos#6  0x00000000005b839a in JimInvokeCommand (interp=interp@entry=0x9a7070, objc=objc@entry=2, objv=objv@entry=0x7fffffffd140) at jim.c:10514
 zephyrproject-rtos#7  0x00000000005b8fbc in Jim_EvalObj (interp=interp@entry=0x9a7070, scriptObjPtr=scriptObjPtr@entry=0x9e96d0) at jim.c:11006
 zephyrproject-rtos#8  0x00000000005bb12b in Jim_EvalSource (interp=interp@entry=0x9a7070, filename=filename@entry=0x0, lineno=lineno@entry=0,
     script=script@entry=0x9e0db0 "verify_image build/zephyr/zephyr.elf") at jim.c:11298
 zephyrproject-rtos#9  0x000000000047df5f in command_run_line (context=context@entry=0x9a7010, line=0x9e0db0 "verify_image build/zephyr/zephyr.elf") at src/helper/command.c:626
 zephyrproject-rtos#10 0x000000000047f6b8 in parse_config_file (cmd_ctx=cmd_ctx@entry=0x9a7010) at src/helper/configuration.c:136
 zephyrproject-rtos#11 0x00000000004053ae in openocd_thread (cmd_ctx=0x9a7010, argv=0x7fffffffd378, argc=18) at src/openocd.c:296
 zephyrproject-rtos#12 openocd_main (argc=18, argv=0x7fffffffd378) at src/openocd.c:356
 zephyrproject-rtos#13 0x00007ffff710d505 in __libc_start_main () from /lib64/libc.so.6
 zephyrproject-rtos#14 0x0000000000404e9e in _start ()
--------------------------->8--------------------------

That happens because we used to have ".checksum_memory" undefined
for ARC. And it was undefined on purpose as we never got to implement
a target-executed applet for CRC calculation.

But there seems to be a work-around of using real memory read back
via JTAG. And for that we just need to return anything != ERROR_OK
from ".checksum_memory()" callback. Which we do here.

Now image verification works for ARC as well!

Signed-off-by: Alexey Brodkin <[email protected]>
stephanosio pushed a commit that referenced this issue Jun 14, 2022
@abrodkin @stephanosio
target/arc: implement dummy checksum_memory()
2a1bf1d 
In zephyrproject-rtos/zephyr#35284 it was
found that use of "verify_image" command for ARC boards lead to
OpenOCD segfault:
--------------------------->8--------------------------
 Program received signal SIGSEGV, Segmentation fault.
 0x0000000000000000 in ?? ()
 (gdb) bt
 #0  0x0000000000000000 in ?? ()
 #1  0x0000000000455e27 in target_checksum_memory (target=target@entry=0xa52450, address=2415919104, size=19952, crc=crc@entry=0x7fffffffcf64) at src/target/target.c:2522
 #2  0x0000000000456066 in handle_verify_image_command_internal (cmd=0x7fffffffd040, verify=IMAGE_VERIFY) at src/target/target.c:3846
 #3  0x000000000047e4ca in run_command (num_words=2, words=0xa80800, c=0x9f3ea0, context=0x9a7010) at src/helper/command.c:582
 #4  exec_command (argv=0x7fffffffd140, argc=<optimized out>, c=0x9f3ea0, cmd_ctx=0x9a7010, interp=0x9a7070) at src/helper/command.c:950
 #5  jim_command_dispatch (interp=0x9a7070, argc=<optimized out>, argv=0x7fffffffd140) at src/helper/command.c:1001
 #6  0x00000000005b839a in JimInvokeCommand (interp=interp@entry=0x9a7070, objc=objc@entry=2, objv=objv@entry=0x7fffffffd140) at jim.c:10514
 #7  0x00000000005b8fbc in Jim_EvalObj (interp=interp@entry=0x9a7070, scriptObjPtr=scriptObjPtr@entry=0x9e96d0) at jim.c:11006
 #8  0x00000000005bb12b in Jim_EvalSource (interp=interp@entry=0x9a7070, filename=filename@entry=0x0, lineno=lineno@entry=0,
     script=script@entry=0x9e0db0 "verify_image build/zephyr/zephyr.elf") at jim.c:11298
 #9  0x000000000047df5f in command_run_line (context=context@entry=0x9a7010, line=0x9e0db0 "verify_image build/zephyr/zephyr.elf") at src/helper/command.c:626
 #10 0x000000000047f6b8 in parse_config_file (cmd_ctx=cmd_ctx@entry=0x9a7010) at src/helper/configuration.c:136
 #11 0x00000000004053ae in openocd_thread (cmd_ctx=0x9a7010, argv=0x7fffffffd378, argc=18) at src/openocd.c:296
 #12 openocd_main (argc=18, argv=0x7fffffffd378) at src/openocd.c:356
 #13 0x00007ffff710d505 in __libc_start_main () from /lib64/libc.so.6
 #14 0x0000000000404e9e in _start ()
--------------------------->8--------------------------

That happens because we used to have ".checksum_memory" undefined
for ARC. And it was undefined on purpose as we never got to implement
a target-executed applet for CRC calculation.

But there seems to be a work-around of using real memory read back
via JTAG. And for that we just need to return anything != ERROR_OK
from ".checksum_memory()" callback. Which we do here.

Now image verification works for ARC as well!

Signed-off-by: Alexey Brodkin <[email protected]>
stephanosio pushed a commit to stephanosio/zephyr-openocd that referenced this issue Jun 14, 2022
@abrodkin @stephanosio
target/arc: implement dummy checksum_memory()
c0d5e24 
In zephyrproject-rtos/zephyr#35284 it was
found that use of "verify_image" command for ARC boards lead to
OpenOCD segfault:
--------------------------->8--------------------------
 Program received signal SIGSEGV, Segmentation fault.
 0x0000000000000000 in ?? ()
 (gdb) bt
 #0  0x0000000000000000 in ?? ()
 zephyrproject-rtos#1  0x0000000000455e27 in target_checksum_memory (target=target@entry=0xa52450, address=2415919104, size=19952, crc=crc@entry=0x7fffffffcf64) at src/target/target.c:2522
 zephyrproject-rtos#2  0x0000000000456066 in handle_verify_image_command_internal (cmd=0x7fffffffd040, verify=IMAGE_VERIFY) at src/target/target.c:3846
 zephyrproject-rtos#3  0x000000000047e4ca in run_command (num_words=2, words=0xa80800, c=0x9f3ea0, context=0x9a7010) at src/helper/command.c:582
 zephyrproject-rtos#4  exec_command (argv=0x7fffffffd140, argc=<optimized out>, c=0x9f3ea0, cmd_ctx=0x9a7010, interp=0x9a7070) at src/helper/command.c:950
 zephyrproject-rtos#5  jim_command_dispatch (interp=0x9a7070, argc=<optimized out>, argv=0x7fffffffd140) at src/helper/command.c:1001
 zephyrproject-rtos#6  0x00000000005b839a in JimInvokeCommand (interp=interp@entry=0x9a7070, objc=objc@entry=2, objv=objv@entry=0x7fffffffd140) at jim.c:10514
 zephyrproject-rtos#7  0x00000000005b8fbc in Jim_EvalObj (interp=interp@entry=0x9a7070, scriptObjPtr=scriptObjPtr@entry=0x9e96d0) at jim.c:11006
 zephyrproject-rtos#8  0x00000000005bb12b in Jim_EvalSource (interp=interp@entry=0x9a7070, filename=filename@entry=0x0, lineno=lineno@entry=0,
     script=script@entry=0x9e0db0 "verify_image build/zephyr/zephyr.elf") at jim.c:11298
 zephyrproject-rtos#9  0x000000000047df5f in command_run_line (context=context@entry=0x9a7010, line=0x9e0db0 "verify_image build/zephyr/zephyr.elf") at src/helper/command.c:626
 zephyrproject-rtos#10 0x000000000047f6b8 in parse_config_file (cmd_ctx=cmd_ctx@entry=0x9a7010) at src/helper/configuration.c:136
 zephyrproject-rtos#11 0x00000000004053ae in openocd_thread (cmd_ctx=0x9a7010, argv=0x7fffffffd378, argc=18) at src/openocd.c:296
 zephyrproject-rtos#12 openocd_main (argc=18, argv=0x7fffffffd378) at src/openocd.c:356
 zephyrproject-rtos#13 0x00007ffff710d505 in __libc_start_main () from /lib64/libc.so.6
 zephyrproject-rtos#14 0x0000000000404e9e in _start ()
--------------------------->8--------------------------

That happens because we used to have ".checksum_memory" undefined
for ARC. And it was undefined on purpose as we never got to implement
a target-executed applet for CRC calculation.

But there seems to be a work-around of using real memory read back
via JTAG. And for that we just need to return anything != ERROR_OK
from ".checksum_memory()" callback. Which we do here.

Now image verification works for ARC as well!

Signed-off-by: Alexey Brodkin <[email protected]>
stephanosio pushed a commit that referenced this issue Jun 14, 2022
@abrodkin @stephanosio
target/arc: implement dummy checksum_memory()
72d96af 
In zephyrproject-rtos/zephyr#35284 it was
found that use of "verify_image" command for ARC boards lead to
OpenOCD segfault:
--------------------------->8--------------------------
 Program received signal SIGSEGV, Segmentation fault.
 0x0000000000000000 in ?? ()
 (gdb) bt
 #0  0x0000000000000000 in ?? ()
 #1  0x0000000000455e27 in target_checksum_memory (target=target@entry=0xa52450, address=2415919104, size=19952, crc=crc@entry=0x7fffffffcf64) at src/target/target.c:2522
 #2  0x0000000000456066 in handle_verify_image_command_internal (cmd=0x7fffffffd040, verify=IMAGE_VERIFY) at src/target/target.c:3846
 #3  0x000000000047e4ca in run_command (num_words=2, words=0xa80800, c=0x9f3ea0, context=0x9a7010) at src/helper/command.c:582
 #4  exec_command (argv=0x7fffffffd140, argc=<optimized out>, c=0x9f3ea0, cmd_ctx=0x9a7010, interp=0x9a7070) at src/helper/command.c:950
 #5  jim_command_dispatch (interp=0x9a7070, argc=<optimized out>, argv=0x7fffffffd140) at src/helper/command.c:1001
 #6  0x00000000005b839a in JimInvokeCommand (interp=interp@entry=0x9a7070, objc=objc@entry=2, objv=objv@entry=0x7fffffffd140) at jim.c:10514
 #7  0x00000000005b8fbc in Jim_EvalObj (interp=interp@entry=0x9a7070, scriptObjPtr=scriptObjPtr@entry=0x9e96d0) at jim.c:11006
 #8  0x00000000005bb12b in Jim_EvalSource (interp=interp@entry=0x9a7070, filename=filename@entry=0x0, lineno=lineno@entry=0,
     script=script@entry=0x9e0db0 "verify_image build/zephyr/zephyr.elf") at jim.c:11298
 #9  0x000000000047df5f in command_run_line (context=context@entry=0x9a7010, line=0x9e0db0 "verify_image build/zephyr/zephyr.elf") at src/helper/command.c:626
 #10 0x000000000047f6b8 in parse_config_file (cmd_ctx=cmd_ctx@entry=0x9a7010) at src/helper/configuration.c:136
 #11 0x00000000004053ae in openocd_thread (cmd_ctx=0x9a7010, argv=0x7fffffffd378, argc=18) at src/openocd.c:296
 #12 openocd_main (argc=18, argv=0x7fffffffd378) at src/openocd.c:356
 #13 0x00007ffff710d505 in __libc_start_main () from /lib64/libc.so.6
 #14 0x0000000000404e9e in _start ()
--------------------------->8--------------------------

That happens because we used to have ".checksum_memory" undefined
for ARC. And it was undefined on purpose as we never got to implement
a target-executed applet for CRC calculation.

But there seems to be a work-around of using real memory read back
via JTAG. And for that we just need to return anything != ERROR_OK
from ".checksum_memory()" callback. Which we do here.

Now image verification works for ARC as well!

Signed-off-by: Alexey Brodkin <[email protected]>
nashif pushed a commit that referenced this issue Feb 14, 2025
@abrodkin @nashif
target/arc: implement dummy checksum_memory()
51dbf70 
In zephyrproject-rtos/zephyr#35284 it was
found that use of "verify_image" command for ARC boards lead to
OpenOCD segfault:
--------------------------->8--------------------------
 Program received signal SIGSEGV, Segmentation fault.
 0x0000000000000000 in ?? ()
 (gdb) bt
 #0  0x0000000000000000 in ?? ()
 #1  0x0000000000455e27 in target_checksum_memory (target=target@entry=0xa52450, address=2415919104, size=19952, crc=crc@entry=0x7fffffffcf64) at src/target/target.c:2522
 #2  0x0000000000456066 in handle_verify_image_command_internal (cmd=0x7fffffffd040, verify=IMAGE_VERIFY) at src/target/target.c:3846
 #3  0x000000000047e4ca in run_command (num_words=2, words=0xa80800, c=0x9f3ea0, context=0x9a7010) at src/helper/command.c:582
 #4  exec_command (argv=0x7fffffffd140, argc=<optimized out>, c=0x9f3ea0, cmd_ctx=0x9a7010, interp=0x9a7070) at src/helper/command.c:950
 #5  jim_command_dispatch (interp=0x9a7070, argc=<optimized out>, argv=0x7fffffffd140) at src/helper/command.c:1001
 #6  0x00000000005b839a in JimInvokeCommand (interp=interp@entry=0x9a7070, objc=objc@entry=2, objv=objv@entry=0x7fffffffd140) at jim.c:10514
 #7  0x00000000005b8fbc in Jim_EvalObj (interp=interp@entry=0x9a7070, scriptObjPtr=scriptObjPtr@entry=0x9e96d0) at jim.c:11006
 #8  0x00000000005bb12b in Jim_EvalSource (interp=interp@entry=0x9a7070, filename=filename@entry=0x0, lineno=lineno@entry=0,
     script=script@entry=0x9e0db0 "verify_image build/zephyr/zephyr.elf") at jim.c:11298
 #9  0x000000000047df5f in command_run_line (context=context@entry=0x9a7010, line=0x9e0db0 "verify_image build/zephyr/zephyr.elf") at src/helper/command.c:626
 #10 0x000000000047f6b8 in parse_config_file (cmd_ctx=cmd_ctx@entry=0x9a7010) at src/helper/configuration.c:136
 #11 0x00000000004053ae in openocd_thread (cmd_ctx=0x9a7010, argv=0x7fffffffd378, argc=18) at src/openocd.c:296
 #12 openocd_main (argc=18, argv=0x7fffffffd378) at src/openocd.c:356
 #13 0x00007ffff710d505 in __libc_start_main () from /lib64/libc.so.6
 #14 0x0000000000404e9e in _start ()
--------------------------->8--------------------------

That happens because we used to have ".checksum_memory" undefined
for ARC. And it was undefined on purpose as we never got to implement
a target-executed applet for CRC calculation.

But there seems to be a work-around of using real memory read back
via JTAG. And for that we just need to return anything != ERROR_OK
from ".checksum_memory()" callback. Which we do here.

Now image verification works for ARC as well!

Signed-off-by: Alexey Brodkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@galak @dgloeck