Fix #175 #182
Merged
Fix #175 #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 4, 2019 11:22
Fall back on ZEPHYR_BASE for backwards compatibility. While we are here, sync up the two versions of this function's way to get the final "start" value, and improve the error message when we fail to find the installation. Fixes: zephyrproject-rtos#175 Signed-off-by: Marti Bolivar <[email protected]>
When running flake8, we should also be ignoring the build directory. Signed-off-by: Marti Bolivar <[email protected]>
Older versions of git don't support this. Since subprocess.check_call() supports a cwd kwarg which provides equivalent functionality, use that instead. Signed-off-by: Marti Bolivar <[email protected]>
carlescufi
approved these changes
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment variable only fix for issue #175 as discussed there.
Roll a couple of other fixes in, one of which also affects the bootstrapper when using older versions of git.
Fixes zephyrproject-rtos/zephyr#12886