Skip to content

Extend _vprintk functionality to parse * #10287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jakub-uC opened this issue Sep 28, 2018 · 2 comments
Closed

Extend _vprintk functionality to parse * #10287

jakub-uC opened this issue Sep 28, 2018 · 2 comments
Assignees
@carlescufi @jakub-uC
Labels
Enhancement Changes/Updates/Additions to existing features

Comments

@jakub-uC
Copy link
Collaborator

Current _vprintk implementation does not support *. It is not possible to parse following data:
"%s%-*s%s:".

Fix can be based on _prf function localized in /lib/libc/minimal/source/stdout/prf.c
@jakub-uC
Copy link
Collaborator Author

Missing this feature causes shell to crash when compiled for POSIX #10195

@jakub-uC jakub-uC self-assigned this Sep 28, 2018
@jakub-uC jakub-uC mentioned this issue Sep 28, 2018
Closed
@nashif nashif added the Enhancement Changes/Updates/Additions to existing features label Sep 30, 2018
jakub-uC pushed a commit to jakub-uC/zephyr that referenced this issue Oct 1, 2018
misc: printk: _vprintk: extending parsing functionality.
1d62a95 
1. Function _vprintk is able to parse '*'.
2. Fixed checkpatch warnings.
3. Added Kconfig option to parse '*' only when SHELL is
   using _vprintk.
4. This PR fixes PR: zephyrproject-rtos#10195 and zephyrproject-rtos#10287

Signed-off-by: Jakub Rzeszutko <[email protected]>
@jakub-uC jakub-uC closed this as completed Oct 1, 2018
@jakub-uC
Copy link
Collaborator Author

jakub-uC commented Oct 1, 2018

Won't be fixed in printk.c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlescufi carlescufi

@jakub-uC jakub-uC

Labels
Enhancement Changes/Updates/Additions to existing features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nashif @carlescufi @jakub-uC