Skip to content

[Coverity CID :188881]Control flow issues in /samples/net/zperf/src/zperf_shell.c #10758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mandarcthorat1 opened this issue Oct 22, 2018 · 0 comments
Closed

[Coverity CID :188881]Control flow issues in /samples/net/zperf/src/zperf_shell.c #10758

mandarcthorat1 opened this issue Oct 22, 2018 · 0 comments
Assignees
@jukkar
Labels
area: Networking area: Samples Samples bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix

Comments

@mandarcthorat1
Copy link
Contributor

Static code scan issues seen in File: /samples/net/zperf/src/zperf_shell.c
Category: Control flow issues
Function: cmd_udp_download
Component: Samples
CID: 188881
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996
@mandarcthorat1 mandarcthorat1 added area: Samples Samples bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix labels Oct 22, 2018
@jukkar jukkar self-assigned this Oct 22, 2018
jukkar added a commit to jukkar/zephyr that referenced this issue Oct 23, 2018
@jukkar
samples: net: zperf: UDP download cmd params incorrectly checked
339e23b 
The "zperf udp download" optional port parameter was not properly
checked, the default port check branch was never reached.
Fix also the same issue in tcp download command.

Coverity-CID: 188881
Fixes zephyrproject-rtos#10758

Signed-off-by: Jukka Rissanen <[email protected]>
@jukkar jukkar mentioned this issue Oct 23, 2018
Merged
jukkar added a commit that referenced this issue Oct 23, 2018
@jukkar
samples: net: zperf: UDP download cmd params incorrectly checked
da699e4 
The "zperf udp download" optional port parameter was not properly
checked, the default port check branch was never reached.
Fix also the same issue in tcp download command.

Coverity-CID: 188881
Fixes #10758

Signed-off-by: Jukka Rissanen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jukkar jukkar

Labels
area: Networking area: Samples Samples bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jukkar @mandarcthorat1