Skip to content

[Coverity CID :189505]Error handling issues in /drivers/sensor/lis2mdl/lis2mdl_trigger.c #11101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mandarcthorat1 opened this issue Nov 5, 2018 · 0 comments
Closed

[Coverity CID :189505]Error handling issues in /drivers/sensor/lis2mdl/lis2mdl_trigger.c #11101

mandarcthorat1 opened this issue Nov 5, 2018 · 0 comments
Labels
area: Drivers bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix

Comments

@mandarcthorat1
Copy link
Contributor

Static code scan issues seen in File: /drivers/sensor/lis2mdl/lis2mdl_trigger.c
Category: Error handling issues
Function: lis2mdl_trigger_set
Component: Drivers
CID: 189505
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996
@mandarcthorat1 mandarcthorat1 added area: Drivers bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix labels Nov 5, 2018
@himanshujha199640 himanshujha199640 mentioned this issue Nov 6, 2018
Merged
himanshujha199640 added a commit to himanshujha199640/zephyr that referenced this issue Nov 6, 2018
@himanshujha199640
sensor: lis2mdl: Handle return value of i2c_burst_read
5f6f3c8 
i2c_burst_read can fail during read/write procedure. Therefore,
add a sanity check for its return value.

Fixes zephyrproject-rtos#11101
Coverity-CID: 189505

Signed-off-by: Himanshu Jha <[email protected]>
MaureenHelm pushed a commit that referenced this issue Nov 6, 2018
@himanshujha199640 @MaureenHelm
sensor: lis2mdl: Handle return value of i2c_burst_read
4a5042d 
i2c_burst_read can fail during read/write procedure. Therefore,
add a sanity check for its return value.

Fixes #11101
Coverity-CID: 189505

Signed-off-by: Himanshu Jha <[email protected]>
nashif pushed a commit that referenced this issue Nov 13, 2018
@himanshujha199640 @nashif
sensor: lis2mdl: Handle return value of i2c_burst_read
3080c8c 
i2c_burst_read can fail during read/write procedure. Therefore,
add a sanity check for its return value.

Fixes #11101
Coverity-CID: 189505

Signed-off-by: Himanshu Jha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: Drivers bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mandarcthorat1