Skip to content

[Coverity CID :189738]Null pointer dereferences in /subsys/net/lib/dns/llmnr_responder.c #11485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mandarcthorat1 opened this issue Nov 19, 2018 · 0 comments
Closed

[Coverity CID :189738]Null pointer dereferences in /subsys/net/lib/dns/llmnr_responder.c #11485

mandarcthorat1 opened this issue Nov 19, 2018 · 0 comments
Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug

Comments

@mandarcthorat1
Copy link
Contributor

Static code scan issues seen in File: /subsys/net/lib/dns/llmnr_responder.c
Category: Null pointer dereferences
Function: create_ipv4_dst_addr
Component: Networking
CID: 189738
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996
@mandarcthorat1 mandarcthorat1 added area: Networking bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix labels Nov 19, 2018
himanshujha199640 added a commit to himanshujha199640/zephyr that referenced this issue Nov 20, 2018
@himanshujha199640
net: llmnr_responder: Check return value of net_udp_get_hdr
fc6b0cc 
net_udp_get_hdr() function returns NULL on failure. Therefore
handle its return value to avoid potential NULL dereference.

Fixes zephyrproject-rtos#11485
Coverity-CID: 189738

Signed-off-by: Himanshu Jha <[email protected]>
@himanshujha199640 himanshujha199640 mentioned this issue Nov 20, 2018
Merged
@galak galak added the priority: medium Medium impact/importance bug label Nov 21, 2018
jukkar pushed a commit that referenced this issue Nov 28, 2018
@himanshujha199640 @jukkar
net: llmnr_responder: Check return value of net_udp_get_hdr
547e757 
net_udp_get_hdr() function returns NULL on failure. Therefore
handle its return value to avoid potential NULL dereference.

Fixes #11485
Coverity-CID: 189738

Signed-off-by: Himanshu Jha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@galak @mandarcthorat1