Skip to content

net: ipv4: udp: broadcast delivery not supported #11617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rmstoi opened this issue Nov 23, 2018 · 2 comments · Fixed by #16172
Closed

net: ipv4: udp: broadcast delivery not supported #11617

rmstoi opened this issue Nov 23, 2018 · 2 comments · Fixed by #16172
Assignees
Labels
area: Conformance Conformance tests area: Networking bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug

Comments

@rmstoi
Copy link
Collaborator

rmstoi commented Nov 23, 2018

Zephyr drops UDP packet with broadcast destination IP and unicast MAC. According to RFC 1122 4.1.1 this scenarion should be supported by UDP: "... to use communications services (e.g., multicast or broadcast delivery) not available from TCP."

ipv4-udp-bcast-dst.pcap.gz

@galak galak added bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug labels Dec 4, 2018
@jukkar
Copy link
Member

jukkar commented Jan 16, 2019

Works for me, perhaps this was already fixed or there was some issue during testing. Anyway, attached is a capture of an UDP packet with broadcast destination address and it was handled by zephyr just fine.

ipv4-udp-bcast-dst-example.pcapng.gz

@rmstoi
Copy link
Collaborator Author

rmstoi commented May 15, 2019

New pcap, with correct Zephyr MAC address.

ipv4-udp-bcast-dst2.pcap.gz

jukkar added a commit to jukkar/zephyr that referenced this issue May 15, 2019
Make sure we are able to receive UDP packets with broadcast
destination address. If CONFIG_NET_IPV4_ACCEPT_ZERO_BROADCAST
is set, then check here also non-standard broadcast address
that is described in RFC 1122 chapter 3.3.6.

Fixes zephyrproject-rtos#11617

Signed-off-by: Jukka Rissanen <[email protected]>
backporting bot pushed a commit that referenced this issue May 20, 2019
Make sure we are able to receive UDP packets with broadcast
destination address. If CONFIG_NET_IPV4_ACCEPT_ZERO_BROADCAST
is set, then check here also non-standard broadcast address
that is described in RFC 1122 chapter 3.3.6.

Fixes #11617

Signed-off-by: Jukka Rissanen <[email protected]>
jukkar added a commit that referenced this issue May 20, 2019
Make sure we are able to receive UDP packets with broadcast
destination address. If CONFIG_NET_IPV4_ACCEPT_ZERO_BROADCAST
is set, then check here also non-standard broadcast address
that is described in RFC 1122 chapter 3.3.6.

Fixes #11617

Signed-off-by: Jukka Rissanen <[email protected]>
nashif pushed a commit to nashif/zephyr that referenced this issue May 21, 2019
Make sure we are able to receive UDP packets with broadcast
destination address. If CONFIG_NET_IPV4_ACCEPT_ZERO_BROADCAST
is set, then check here also non-standard broadcast address
that is described in RFC 1122 chapter 3.3.6.

Fixes zephyrproject-rtos#11617

Signed-off-by: Jukka Rissanen <[email protected]>
nashif pushed a commit that referenced this issue May 21, 2019
Make sure we are able to receive UDP packets with broadcast
destination address. If CONFIG_NET_IPV4_ACCEPT_ZERO_BROADCAST
is set, then check here also non-standard broadcast address
that is described in RFC 1122 chapter 3.3.6.

Fixes #11617

Signed-off-by: Jukka Rissanen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Conformance Conformance tests area: Networking bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants