Skip to content

"make htmldocs" reports a cmake warning #12282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dbkinder opened this issue Jan 3, 2019 · 0 comments · Fixed by #12287
Closed

"make htmldocs" reports a cmake warning #12282

dbkinder opened this issue Jan 3, 2019 · 0 comments · Fixed by #12287
Labels
area: Build System area: Documentation bug The issue is a bug, or the PR is fixing a bug

Comments

@dbkinder
Copy link
Contributor

dbkinder commented Jan 3, 2019

Describe the bug
Documentation build (e.g. "make htmldocs") reports a cmake warning:

VERSION keyword not followed by a value or was followed by a value that
expanded to nothing.

Doc build does complete successfully, so this is just an unexpected warning. Does something depend on the VERSION environment variable being set?

To Reproduce

~$ cmake --version
cmake version 3.13.2

CMake suite maintained and supported by Kitware (kitware.com/cmake).
~$ cd zephyr
~/zephyr$ source zephyr-env.sh
~/zephyr$ time make htmldocs
mkdir -p doc/_build && cmake -GNinja -DDOC_TAG=development -DSPHINXOPTS=-q -Bdoc/_build -Hdoc/ && ninja -C doc/_build htmldocs
CMake Warning at CMakeLists.txt:2 (project):
  VERSION keyword not followed by a value or was followed by a value that
  expanded to nothing.

Environment (please complete the following information):

  • OS: Ubuntu 18.04.1 LTS
@dbkinder dbkinder added bug The issue is a bug, or the PR is fixing a bug area: Build System area: Documentation labels Jan 3, 2019
SebastianBoe added a commit to SebastianBoe/zephyr that referenced this issue Jan 4, 2019
@SebastianBoe
cmake: Fix VERSION warning in doc build
7159d97 
The 'doc' build has been invoking 'project' with the argument "VERSION
${PROJECT_VERSION}". This is cargo-cult code inherited from the
toplevel build system.

This can be safely removed because in the doc build the versioning
variables that are set by 'project' are unused and PROJECT_VERSION is
not available to be de-referenced at that point in time any way ...

This fixes zephyrproject-rtos#12282

Signed-off-by: Sebastian Bøe <[email protected]>
@SebastianBoe SebastianBoe mentioned this issue Jan 4, 2019
Merged
carlescufi pushed a commit that referenced this issue Jan 4, 2019
@SebastianBoe @carlescufi
cmake: Fix VERSION warning in doc build
5748fe1 
The 'doc' build has been invoking 'project' with the argument "VERSION
${PROJECT_VERSION}". This is cargo-cult code inherited from the
toplevel build system.

This can be safely removed because in the doc build the versioning
variables that are set by 'project' are unused and PROJECT_VERSION is
not available to be de-referenced at that point in time any way ...

This fixes #12282

Signed-off-by: Sebastian Bøe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: Build System area: Documentation bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmake: Fix VERSION warning in doc build SebastianBoe/zephyr
1 participant
@dbkinder