ext: stm32: revert fix https://github.com/zephyrproject-rtos/zephyr/pull/8762 #12609
Assignees
Labels
area: I2S
bug
The issue is a bug, or the PR is fixing a bug
platform: STM32
ST Micro STM32
priority: medium
Medium impact/importance bug
Milestone
Comments
erwango
added
bug
avisconti
added a commit
to avisconti/zephyr
that referenced
this issue
Jan 22, 2019
Revert 71ba2de: ext: stm32cube: stm32f4xx: shift I2SR field in PLLI2SCFGR register (ST Bug tracker ID: 50086) Revert 9a89320: ext: stm32cube: stm32f7xx: shift I2SR field in PLLI2SCFGR register (ST Bug tracker ID: 50108) This two commits were introduced to shift the PLLR parameter according to the PLL register field position. After analysis, it appears that function is actually correct, and issue was actually in parameters provided that didn't match the API. (see PR zephyrproject-rtos#12609) Signed-off-by: Armando Visconti <[email protected]>
avisconti
added a commit
to avisconti/zephyr
that referenced
this issue
Jan 23, 2019
The PLLR parameter in LL_RCC_PLLI2S_ConfigDomain_I2S() API should be selected among the following list of (already shifted) values: * @arg @ref LL_RCC_PLLI2SR_DIV_2 * @arg @ref LL_RCC_PLLI2SR_DIV_3 * @arg @ref LL_RCC_PLLI2SR_DIV_4 * @arg @ref LL_RCC_PLLI2SR_DIV_5 * @arg @ref LL_RCC_PLLI2SR_DIV_6 * @arg @ref LL_RCC_PLLI2SR_DIV_7 This commit fixes PR zephyrproject-rtos#12609. Signed-off-by: Armando Visconti <[email protected]>
galak
pushed a commit
that referenced
this issue
Jan 24, 2019
Revert 71ba2de: ext: stm32cube: stm32f4xx: shift I2SR field in PLLI2SCFGR register (ST Bug tracker ID: 50086) Revert 9a89320: ext: stm32cube: stm32f7xx: shift I2SR field in PLLI2SCFGR register (ST Bug tracker ID: 50108) This two commits were introduced to shift the PLLR parameter according to the PLL register field position. After analysis, it appears that function is actually correct, and issue was actually in parameters provided that didn't match the API. (see PR #12609) Signed-off-by: Armando Visconti <[email protected]>
galak
pushed a commit
that referenced
this issue
Jan 24, 2019
The PLLR parameter in LL_RCC_PLLI2S_ConfigDomain_I2S() API should be selected among the following list of (already shifted) values: * @arg @ref LL_RCC_PLLI2SR_DIV_2 * @arg @ref LL_RCC_PLLI2SR_DIV_3 * @arg @ref LL_RCC_PLLI2SR_DIV_4 * @arg @ref LL_RCC_PLLI2SR_DIV_5 * @arg @ref LL_RCC_PLLI2SR_DIV_6 * @arg @ref LL_RCC_PLLI2SR_DIV_7 This commit fixes PR #12609. Signed-off-by: Armando Visconti <[email protected]>
|
Closing this issue as addressed by #12637 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
A fix was introduced in ext to fix LL API function.
After analysis, it appears that function is actually correct, and issue was actually in parameters provided that didn't match the API.
Revert fix introduced in API and fix use of API (in drivers/i2s/i2s_ll_stm32.c)
To Reproduce
NA
Expected behavior
NA
Impact
Wrong waveform generated
Screenshots or console output
NA
Environment (please complete the following information):
NA
Additional context
In drivers/i2s/i2s_ll_stm32.c, function
LL_RCC_PLLI2S_ConfigDomain_I2S, parameterPLLRshould be one of:which are actually already shifted values.
The text was updated successfully, but these errors were encountered: