Skip to content

Coverage broken for nrf52_bsim #13009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aescolar opened this issue Feb 3, 2019 · 0 comments
Closed

Coverage broken for nrf52_bsim #13009

aescolar opened this issue Feb 3, 2019 · 0 comments
Assignees
@aescolar
Labels
bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug

Comments

@aescolar
Copy link
Member

aescolar commented Feb 3, 2019 •
edited
Loading

Describe the bug
Coverage reports are missing for the nrf52_bsim board (both in codecov and when attempting to generate them locally)
COVERAGE cannot be set for nrf52_bsim (or any other NATIVE_APPLICATION board)

To Reproduce
Steps to reproduce the behavior:

  1. mkdir build; cd build
  2. cmake -DBOARD=nrf52_bsim -DCONFIG_COVERAGE=y
  3. See complaint from kconfig about COVERAGE not being selectable for this board

Expected behavior
should be possible to set COVERAGE for any NATIVE_APLICATION as it was before.

Impact
No coverage reports are generated in CI for the nrf52_bsim board ; all coverage for the bluetooth subsystem are missing.
No coverage reports can be generated locally for other NATIVE_APPLICATIONS than native_posix.

Environment (please complete the following information):

Additional context
Related to #12571, introduced in #9717

Patch incoming
@aescolar aescolar added bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug labels Feb 3, 2019
@aescolar aescolar self-assigned this Feb 3, 2019
aescolar added a commit to aescolar/zephyr that referenced this issue Feb 3, 2019
@aescolar
coverage: Bugfix: Missing coverage in nrf52_bsim
3128eb0 
In zephyrproject-rtos#9717, 777407b
coverage support was broken for all NATIVE_APPLICATION except
native_posix
This includes the nrf52_bsim board
Fix it.

Fixes: zephyrproject-rtos#13009

Signed-off-by: Alberto Escolar Piedras <[email protected]>
@aescolar aescolar mentioned this issue Feb 3, 2019
Merged
nashif pushed a commit that referenced this issue Feb 3, 2019
@aescolar @nashif
coverage: Bugfix: Missing coverage in nrf52_bsim
2cd70e6 
In #9717, 777407b
coverage support was broken for all NATIVE_APPLICATION except
native_posix
This includes the nrf52_bsim board
Fix it.

Fixes: #13009

Signed-off-by: Alberto Escolar Piedras <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aescolar aescolar

Labels
bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aescolar