Skip to content

sanitycheck miss extra_args: OVERLAY_CONFIG parameter #13320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
finikorg opened this issue Feb 12, 2019 · 0 comments
Closed

sanitycheck miss extra_args: OVERLAY_CONFIG parameter #13320

finikorg opened this issue Feb 12, 2019 · 0 comments
Assignees
@nashif
Labels
area: Sanitycheck Sanitycheck has been renamed to Twister bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@finikorg
Copy link
Collaborator

Describe the bug
We have several sample.yaml for example in samples/net/zperf/ with following overlay configuration:

  test_netusb_ecm:
    extra_args: OVERLAY_CONFIG="overlay-netusb.conf"
    extra_configs:
      - CONFIG_NET_TCP=n
      - CONFIG_SHELL_CMDS=n
    tags: usb net zperf
    depends_on: usb_device

For some reason sanitycheck misses all configuration from overlay files.

To Reproduce
Steps to reproduce the behavior:

sanitycheck -t zperf

Expected behavior
Should check with overlay config included

Impact
Does not test overlays
@finikorg finikorg added bug The issue is a bug, or the PR is fixing a bug area: Sanitycheck Sanitycheck has been renamed to Twister labels Feb 12, 2019
@nashif nashif self-assigned this Feb 12, 2019
@nashif nashif added the priority: low Low impact/importance bug label Feb 12, 2019
@nashif nashif mentioned this issue Feb 12, 2019
Merged
nashif added a commit to nashif/zephyr that referenced this issue Feb 13, 2019
@nashif
sanitycheck: do no overide OVERLAY_CONFIG
ff72da7 
We have been overriding OVERLAY_CONFIG coming from tests. Concat all
files and create one variable that we pass to kconfig as list.

Fixes zephyrproject-rtos#13320

Signed-off-by: Anas Nashif <[email protected]>
nashif added a commit that referenced this issue Feb 18, 2019
@nashif
sanitycheck: do no overide OVERLAY_CONFIG
f9e73c9 
We have been overriding OVERLAY_CONFIG coming from tests. Concat all
files and create one variable that we pass to kconfig as list.

Fixes #13320

Signed-off-by: Anas Nashif <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nashif nashif

Labels
area: Sanitycheck Sanitycheck has been renamed to Twister bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nashif @finikorg