Skip to content

CAN tests don't build #13716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
galak opened this issue Feb 24, 2019 · 1 comment
Closed

CAN tests don't build #13716

galak opened this issue Feb 24, 2019 · 1 comment
Assignees
@jukkar
Labels
area: CAN bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Milestone
v1.14.0

Comments

@galak
Copy link
Collaborator

galak commented Feb 24, 2019

Trying to run the can tests:

./scripts/sanitycheck -T tests/drivers/can/ -l

We get:

4 tests selected, 314 tests discarded due to filters
total complete:    0/   4   0%  failed:    0

stm32f072b_disco          tests/drivers/can/api/peripheral.can               FAILED: build_error
	see: sanity-out/stm32f072b_disco/tests/drivers/can/api/peripheral.can/build.log

total complete:    1/   4  25%  failed:    1

stm32f072b_disco          tests/drivers/can/stm32/peripheral.can             FAILED: build_error
	see: sanity-out/stm32f072b_disco/tests/drivers/can/stm32/peripheral.can/build.log

total complete:    2/   4  50%  failed:    2

nucleo_l432kc             tests/drivers/can/api/peripheral.can               FAILED: build_error
	see: sanity-out/nucleo_l432kc/tests/drivers/can/api/peripheral.can/build.log

total complete:    3/   4  75%  failed:    3

nucleo_l432kc             tests/drivers/can/stm32/peripheral.can             FAILED: build_error
	see: sanity-out/nucleo_l432kc/tests/drivers/can/stm32/peripheral.can/build.log

total complete:    4/   4  100%  failed:    4
0 of 4 tests passed with 0 warnings in 3 seconds

There are 2 different issues here, one is the tests didn't get updated with change in PR #13374. Second is enabling of the STM32 CAN driver.

The second issue is addressed by PR #13715
@galak galak added the bug The issue is a bug, or the PR is fixing a bug label Feb 24, 2019
@galak galak added this to the v1.14.0 milestone Feb 24, 2019
@galak galak added the priority: medium Medium impact/importance bug label Feb 24, 2019
@nashif nashif changed the title can tests don't build CAN tests don't build Feb 24, 2019
@jukkar jukkar mentioned this issue Feb 24, 2019
Merged
@jukkar
Copy link
Member

jukkar commented Feb 24, 2019 •
edited
Loading

I do not understand how the #13374 managed to pass the sanity tests. Any idea what went wrong there?

jukkar added a commit to jukkar/zephyr that referenced this issue Feb 24, 2019
@jukkar
tests: can: Fix name of CAN msg and filter structs
b2609af 
The name of the CAN message and filter was changed so this
needs to be changed too here.

Fixes zephyrproject-rtos#13716

Signed-off-by: Jukka Rissanen <[email protected]>
galak pushed a commit that referenced this issue Feb 25, 2019
@jukkar @galak
tests: can: Fix name of CAN msg and filter structs
23ba884 
The name of the CAN message and filter was changed so this
needs to be changed too here.

Fixes #13716

Signed-off-by: Jukka Rissanen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jukkar jukkar

Labels
area: CAN bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Milestone
v1.14.0
Development

No branches or pull requests
2 participants
@jukkar @galak