Skip to content

*_UART_NS16550_PORT_{2,3}_* seems to be a (possibly broken) Kconfig/DTS mishmash #13753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ulfalizer opened this issue Feb 25, 2019 · 3 comments
Closed

*_UART_NS16550_PORT_{2,3}_* seems to be a (possibly broken) Kconfig/DTS mishmash #13753

ulfalizer opened this issue Feb 25, 2019 · 3 comments
Assignees
@vonhust @galak @dcpleung
Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@ulfalizer
Copy link
Collaborator

These symbols are referenced but never defined:

CONFIG_UART_NS16550_PORT_2_BAUD_RATE
CONFIG_UART_NS16550_PORT_2_IRQ_FLAGS
CONFIG_UART_NS16550_PORT_2_IRQ_PRI
CONFIG_UART_NS16550_PORT_2_NAME
CONFIG_UART_NS16550_PORT_3_BASE_ADDR
CONFIG_UART_NS16550_PORT_3_BAUD_RATE
CONFIG_UART_NS16550_PORT_3_CLK_FREQ
CONFIG_UART_NS16550_PORT_3_IRQ
CONFIG_UART_NS16550_PORT_3_IRQ_FLAGS
CONFIG_UART_NS16550_PORT_3_IRQ_PRI
CONFIG_UART_NS16550_PORT_3_NAME

Some of the CONFIG_* macros seem to get defined with a DT_* prefix instead:

$ git grep UART_NS16550_PORT_3_BASE_ADDR
drivers/serial/uart_ns16550.c:  .port = CONFIG_UART_NS16550_PORT_3_BASE_ADDR,
soc/arc/snps_arc_iot/dts_fixup.h:#define DT_UART_NS16550_PORT_3_BASE_ADDR DT_NS16550_80014300_BASE_ADDRESS
soc/x86/apollo_lake/soc.c:MMU_BOOT_REGION(CONFIG_UART_NS16550_PORT_3_BASE_ADDR, 0x1000,
@ulfalizer ulfalizer added the bug The issue is a bug, or the PR is fixing a bug label Feb 25, 2019
@ulfalizer ulfalizer changed the title *_UART_NS16550_PORT_{2,3}_* seems to be a (possibly broken) Kconfig/DTS mismash *_UART_NS16550_PORT_{2,3}_* seems to be a (possibly broken) Kconfig/DTS mishmash Feb 25, 2019
@dcpleung
Copy link
Member

@vonhust Could you take a look at soc/arc/snps_arc_iot/dts_fixup.h to see if those are defined correctly?

@ulfalizer
Copy link
Collaborator Author

Would be nice to get rid of those CONFIG_* prefixes on stuff that isn't from Kconfig in any case.

@dcpleung
Copy link
Member

Previous renames from CONFIG_* to DT_* missed a few. Looking into the remaining ones now...

dcpleung added a commit to dcpleung/zephyr that referenced this issue Feb 26, 2019
@dcpleung
uart/ns16550: Use DT_ prefix for remaining device configs
c1e7b4e 
Previous rename from CONFIG_* to DT_* left a few remaining
CONFIG_*. So rename them manually now.

Fix zephyrproject-rtos#13753

Signed-off-by: Daniel Leung <[email protected]>
@dcpleung dcpleung mentioned this issue Feb 26, 2019
Merged
@dcpleung dcpleung added the priority: low Low impact/importance bug label Feb 27, 2019
galak pushed a commit that referenced this issue Feb 27, 2019
@dcpleung @galak
uart/ns16550: Use DT_ prefix for remaining device configs
603f068 
Previous rename from CONFIG_* to DT_* left a few remaining
CONFIG_*. So rename them manually now.

Fix #13753

Signed-off-by: Daniel Leung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vonhust vonhust

@galak galak

@dcpleung dcpleung

Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ulfalizer @vonhust @galak @dcpleung