Skip to content

[Coverity CID :190996]Integer handling issues in /drivers/can/stm32_can.c #13829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mandarcthorat1 opened this issue Feb 27, 2019 · 0 comments
Closed

[Coverity CID :190996]Integer handling issues in /drivers/can/stm32_can.c #13829

mandarcthorat1 opened this issue Feb 27, 2019 · 0 comments
Assignees
@alexanderwachter
Labels
area: CAN area: Drivers bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug

Comments

@mandarcthorat1
Copy link
Contributor

Static code scan issues seen in File: /drivers/can/stm32_can.c
Category: Integer handling issues
Function: can_stm32_set_filter
Component: Drivers
CID: 190996
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996
@mandarcthorat1 mandarcthorat1 added area: Drivers bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix labels Feb 27, 2019
@galak galak added area: CAN priority: medium Medium impact/importance bug labels Feb 27, 2019
maxxlife added a commit to maxxlife/zephyr that referenced this issue Feb 28, 2019
@maxxlife
can: cast value 1U to type u64_t in function can_stm32_set_filter
c316ba0 
Potentially overflowing expression 1U << register_demand
I changed to (u64_t)1U << register_demand
To avoid overflow, I casted 1U to type u64_t.

Coverity-CID: 190996
Fixes: zephyrproject-rtos#13829
Signed-off-by: Maksim Masalski <[email protected]>
@maxxlife maxxlife mentioned this issue Feb 28, 2019
Merged
maxxlife added a commit to maxxlife/zephyr that referenced this issue Feb 28, 2019
@maxxlife
can: cast value 1U to type ULL in function can_stm32_set_filter
3164994 
Potentially overflowing expression 1U << register_demand
changed to the 1ULL << register_demand to avoid overflow.

Coverity-CID: 190996
Fixes: zephyrproject-rtos#13829
Signed-off-by: Maksim Masalski <[email protected]>
andrewboie pushed a commit that referenced this issue Mar 1, 2019
@maxxlife @andrewboie
can: cast value 1U to type u64_t in function can_stm32_set_filter
f32b94c 
Potentially overflowing expression 1U << register_demand
I changed to (u64_t)1U << register_demand
To avoid overflow, I casted 1U to type u64_t.

Coverity-CID: 190996
Fixes: #13829
Signed-off-by: Maksim Masalski <[email protected]>
andrewboie pushed a commit that referenced this issue Mar 1, 2019
@maxxlife @andrewboie
can: cast value 1U to type ULL in function can_stm32_set_filter
9f8db3d 
Potentially overflowing expression 1U << register_demand
changed to the 1ULL << register_demand to avoid overflow.

Coverity-CID: 190996
Fixes: #13829
Signed-off-by: Maksim Masalski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderwachter alexanderwachter

Labels
area: CAN area: Drivers bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexanderwachter @galak @mandarcthorat1