Skip to content

[Coverity CID :190958]Control flow issues in /samples/boards/96b_argonkey/microphone/src/main.c #13857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mandarcthorat1 opened this issue Feb 27, 2019 · 1 comment
Closed

[Coverity CID :190958]Control flow issues in /samples/boards/96b_argonkey/microphone/src/main.c #13857

mandarcthorat1 opened this issue Feb 27, 2019 · 1 comment
Assignees
@avisconti
Labels
area: Boards area: Samples Samples bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug

Comments

@mandarcthorat1
Copy link
Contributor

Static code scan issues seen in File: /samples/boards/96b_argonkey/microphone/src/main.c
Category: Control flow issues
Function: main
Component: Samples
CID: 190958
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996
@mandarcthorat1 mandarcthorat1 added area: Samples Samples bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix labels Feb 27, 2019
@galak galak added priority: low Low impact/importance bug area: Boards labels Feb 27, 2019
avisconti added a commit to avisconti/zephyr that referenced this issue Feb 27, 2019
@avisconti
samples/96b_argonkey: microphone: Fix coverity bug 190958
e4e6de4 
Fix coverity CID 190958: Logically dead code (DEADCODE)
(bug: zephyrproject-rtos#13857)

Condition (ret < 0) was tested, but 'ret' variable was not
assigned.

Signed-off-by: Armando Visconti <[email protected]>
@avisconti avisconti mentioned this issue Feb 27, 2019
Merged
galak pushed a commit that referenced this issue Feb 27, 2019
@avisconti @galak
samples/96b_argonkey: microphone: Fix coverity bug 190958
16dc36b 
Fix coverity CID 190958: Logically dead code (DEADCODE)
(bug: #13857)

Condition (ret < 0) was tested, but 'ret' variable was not
assigned.

Signed-off-by: Armando Visconti <[email protected]>
@galak
Copy link
Collaborator

galak commented Mar 7, 2019

Resolved by merge of #13900

@galak galak closed this as completed Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@avisconti avisconti

Labels
area: Boards area: Samples Samples bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@avisconti @galak @mandarcthorat1