Skip to content

[Coverity CID :190953]Error handling issues in /subsys/fs/shell.c #13862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mandarcthorat1 opened this issue Feb 27, 2019 · 0 comments
Closed

[Coverity CID :190953]Error handling issues in /subsys/fs/shell.c #13862

mandarcthorat1 opened this issue Feb 27, 2019 · 0 comments
Labels
area: File System area: Other bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug

Comments

@mandarcthorat1
Copy link
Contributor

Static code scan issues seen in File: /subsys/fs/shell.c
Category: Error handling issues
Function: cmd_read
Component: Other
CID: 190953
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996
@mandarcthorat1 mandarcthorat1 added area: Other bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix labels Feb 27, 2019
@galak galak added priority: medium Medium impact/importance bug area: File System labels Feb 27, 2019
@dcpleung dcpleung mentioned this issue Mar 1, 2019
Merged
dcpleung added a commit to dcpleung/zephyr that referenced this issue Mar 1, 2019
@dcpleung
subsys/fs/shell: fix unchecked return from fs_seek in cmd_read
3f922d5 
Inside cmd_read(), result of fs_seek() is not checked which might
result in reading the wrong part of file. So fails the read if
fs_seek() fails.

Fixes zephyrproject-rtos#13862
Fixes CID-190953

Signed-off-by: Daniel Leung <[email protected]>
nashif pushed a commit that referenced this issue Mar 2, 2019
@dcpleung @nashif
subsys/fs/shell: fix unchecked return from fs_seek in cmd_read
73ee371 
Inside cmd_read(), result of fs_seek() is not checked which might
result in reading the wrong part of file. So fails the read if
fs_seek() fails.

Fixes #13862
Fixes CID-190953

Signed-off-by: Daniel Leung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: File System area: Other bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@galak @mandarcthorat1