Skip to content

[Coverity CID :190933]Control flow issues in /drivers/gpio/gpio_intel_apl.c #13880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mandarcthorat1 opened this issue Feb 27, 2019 · 0 comments · Fixed by #13920
Closed

[Coverity CID :190933]Control flow issues in /drivers/gpio/gpio_intel_apl.c #13880

mandarcthorat1 opened this issue Feb 27, 2019 · 0 comments · Fixed by #13920
Assignees
@dcpleung
Labels
area: Drivers area: GPIO bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug

Comments

@mandarcthorat1
Copy link
Contributor

Static code scan issues seen in File: /drivers/gpio/gpio_intel_apl.c
Category: Control flow issues
Function: gpio_intel_apl_config
Component: Drivers
CID: 190933
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996
@mandarcthorat1 mandarcthorat1 added area: Drivers bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix labels Feb 27, 2019
@galak galak added priority: medium Medium impact/importance bug area: GPIO labels Feb 27, 2019
@dcpleung dcpleung mentioned this issue Feb 27, 2019
Merged
dcpleung added a commit to dcpleung/zephyr that referenced this issue Feb 28, 2019
@dcpleung
gpio: gpio_intel_apl: fix if condition leading to dead code
c75e3df 
GPIO_INT_ACTIVE_LOW is 0 which means it cannot be simply AND-ed.
So fix the condition.

Fixes zephyrproject-rtos#13880

Signed-off-by: Daniel Leung <[email protected]>
andrewboie pushed a commit that referenced this issue Feb 28, 2019
@dcpleung @andrewboie
gpio: gpio_intel_apl: fix if condition leading to dead code
1af5fa1 
GPIO_INT_ACTIVE_LOW is 0 which means it cannot be simply AND-ed.
So fix the condition.

Fixes #13880

Signed-off-by: Daniel Leung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcpleung dcpleung

Labels
area: Drivers area: GPIO bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gpio: gpio_intel_apl: fix if condition leading to dead code dcpleung/zephyr
3 participants
@galak @mandarcthorat1 @dcpleung