Skip to content

[Coverity CID :190932]Control flow issues in /samples/subsys/ipc/openamp/src/main.c #13881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mandarcthorat1 opened this issue Feb 27, 2019 · 0 comments
Closed

[Coverity CID :190932]Control flow issues in /samples/subsys/ipc/openamp/src/main.c #13881

mandarcthorat1 opened this issue Feb 27, 2019 · 0 comments
Assignees
@galak
Labels
area: Samples Samples bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug

Comments

@mandarcthorat1
Copy link
Contributor

Static code scan issues seen in File: /samples/subsys/ipc/openamp/src/main.c
Category: Control flow issues
Function: app_task
Component: Samples
CID: 190932
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996
@mandarcthorat1 mandarcthorat1 added area: Samples Samples bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix labels Feb 27, 2019
@galak galak self-assigned this Feb 27, 2019
@galak galak added the priority: low Low impact/importance bug label Feb 27, 2019
galak added a commit to galak/zephyr that referenced this issue Feb 28, 2019
@galak
samples: ipc: openamp: Fix missed return error check
03d14f7 
The return from ipm_set_enabled wasn't assigned to 'status' so the check
right after the call to ipm_set_enabled() wasn't doing the right thing.

Fixes: zephyrproject-rtos#13881
Coverity CID: 190932

Signed-off-by: Kumar Gala <[email protected]>
@nashif nashif closed this as completed in 11b3dce Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galak galak

Labels
area: Samples Samples bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@galak @mandarcthorat1