Skip to content

[Coverity CID :190931]Control flow issues in /subsys/net/lib/lwm2m/lwm2m_rw_json.c #13882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mandarcthorat1 opened this issue Feb 27, 2019 · 0 comments
Closed

[Coverity CID :190931]Control flow issues in /subsys/net/lib/lwm2m/lwm2m_rw_json.c #13882

mandarcthorat1 opened this issue Feb 27, 2019 · 0 comments
Assignees
@mike-scott
Labels
area: LWM2M area: Networking bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug

Comments

@mandarcthorat1
Copy link
Contributor

Static code scan issues seen in File: /subsys/net/lib/lwm2m/lwm2m_rw_json.c
Category: Control flow issues
Function: read_number
Component: Networking
CID: 190931
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996
@mandarcthorat1 mandarcthorat1 added area: Networking bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix labels Feb 27, 2019
@galak galak added priority: medium Medium impact/importance bug area: LWM2M labels Feb 27, 2019
@mike-scott mike-scott mentioned this issue Feb 27, 2019
Merged
mike-scott added a commit to mike-scott/zephyr that referenced this issue Feb 27, 2019
@mike-scott
net: lwm2m: fix json NULL deref / code flow in read_number()
aac23ef 
Per Coverity report, we are assigning the value1 and value2
s64_t pointers a value of 0.  Later when we go to use value1
and value2, they are of course ... NULL.

Fix the typos in the initial assignment of 0 to the
references of value1 and value2.

Fixes: zephyrproject-rtos#13867
Fixes: zephyrproject-rtos#13882

Signed-off-by: Michael Scott <[email protected]>
mike-scott added a commit to mike-scott/zephyr that referenced this issue Feb 28, 2019
@mike-scott
[FIO fromlist] net: lwm2m: fix json NULL deref / code flow in read_nu…
d169024 
…mber()

Per Coverity report, we are assigning the value1 and value2
s64_t pointers a value of 0.  Later when we go to use value1
and value2, they are of course ... NULL.

Fix the typos in the initial assignment of 0 to the
references of value1 and value2.

Fixes: zephyrproject-rtos#13867
Fixes: zephyrproject-rtos#13882

Signed-off-by: Michael Scott <[email protected]>
nashif pushed a commit that referenced this issue Mar 1, 2019
@mike-scott @nashif
net: lwm2m: fix json NULL deref / code flow in read_number()
0482b66 
Per Coverity report, we are assigning the value1 and value2
s64_t pointers a value of 0.  Later when we go to use value1
and value2, they are of course ... NULL.

Fix the typos in the initial assignment of 0 to the
references of value1 and value2.

Fixes: #13867
Fixes: #13882

Signed-off-by: Michael Scott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mike-scott mike-scott

Labels
area: LWM2M area: Networking bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mike-scott @galak @mandarcthorat1