Skip to content

[Coverity CID :190926]Error handling issues in /drivers/can/stm32_can.c #13886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mandarcthorat1 opened this issue Feb 27, 2019 · 0 comments
Closed

[Coverity CID :190926]Error handling issues in /drivers/can/stm32_can.c #13886

mandarcthorat1 opened this issue Feb 27, 2019 · 0 comments
Assignees
@alexanderwachter
Labels
area: CAN area: Drivers bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug

Comments

@mandarcthorat1
Copy link
Contributor

Static code scan issues seen in File: /drivers/can/stm32_can.c
Category: Error handling issues
Function: can_stm32_runtime_configure
Component: Drivers
CID: 190926
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996
@mandarcthorat1 mandarcthorat1 added area: Drivers bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix labels Feb 27, 2019
@galak galak added area: CAN priority: medium Medium impact/importance bug labels Feb 27, 2019
@maxxlife maxxlife mentioned this issue Mar 3, 2019
Merged
@nashif nashif added the In progress For PRs: is work in progress and should not be merged yet. For issues: Is being worked on label Mar 4, 2019
@galak galak added bug The issue is a bug, or the PR is fixing a bug and removed bug The issue is a bug, or the PR is fixing a bug labels Mar 12, 2019
maxxlife added a commit to maxxlife/zephyr that referenced this issue Mar 16, 2019
@maxxlife
can: fix unchecked return from clock_control_get_rate
ecbddbb 
Inside can_stm32_runtime_configure() result of
clock_control_get_rate() is not checked which might result that
function can return error and that error can not be handled

Coverity-CID: 190926
Fixes: zephyrproject-rtos#13886
Signed-off-by: Maksim Masalski <[email protected]>
@ghost ghost removed the In progress For PRs: is work in progress and should not be merged yet. For issues: Is being worked on label Mar 27, 2019
nashif pushed a commit that referenced this issue Mar 27, 2019
@maxxlife @nashif
can: fix unchecked return from clock_control_get_rate
d1f3bba 
Inside can_stm32_runtime_configure() result of
clock_control_get_rate() is not checked which might result that
function can return error and that error can not be handled

Coverity-CID: 190926
Fixes: #13886
Signed-off-by: Maksim Masalski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderwachter alexanderwachter

Labels
area: CAN area: Drivers bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nashif @alexanderwachter @galak @mandarcthorat1