Skip to content

[Coverity CID :195880]Null pointer dereferences in /tests/net/dhcpv4/src/main.c #14395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aasthagr opened this issue Mar 12, 2019 · 1 comment
Closed

[Coverity CID :195880]Null pointer dereferences in /tests/net/dhcpv4/src/main.c #14395

aasthagr opened this issue Mar 12, 2019 · 1 comment
Assignees
@jukkar
Labels
area: Networking area: Tests Issues related to a particular existing or missing test bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug

Comments

@aasthagr
Copy link
Collaborator

Static code scan issues seen in File: /tests/net/dhcpv4/src/main.c
Category: Null pointer dereferences
Function: prepare_dhcp_ack
Component: Tests
CID: 195880
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996
@galak galak added Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug priority: low Low impact/importance bug area: Tests Issues related to a particular existing or missing test bug The issue is a bug, or the PR is fixing a bug and removed priority: medium Medium impact/importance bug area: Tests Issues related to a particular existing or missing test bug The issue is a bug, or the PR is fixing a bug labels Mar 12, 2019
@tedd-an tedd-an self-assigned this Mar 13, 2019
@jukkar
Copy link
Member

jukkar commented Mar 13, 2019

This is related to #14413 so I can fix it in the same PR.

@jukkar jukkar assigned jukkar and unassigned tedd-an Mar 13, 2019
jukkar added a commit to jukkar/zephyr that referenced this issue Mar 13, 2019
@jukkar
tests: net: dhcpv4: Check null ptr dereference
38f7aa8 
If pkt allocation fails, then prepare to handle NULL pointer.

Coverity-CID: 195880
Coverity-CID: 195816

Fixes zephyrproject-rtos#14413
Fixes zephyrproject-rtos#14395

Signed-off-by: Jukka Rissanen <[email protected]>
@jukkar jukkar mentioned this issue Mar 13, 2019
Merged
galak pushed a commit that referenced this issue Mar 13, 2019
@jukkar @galak
tests: net: dhcpv4: Check null ptr dereference
55cd97b 
If pkt allocation fails, then prepare to handle NULL pointer.

Coverity-CID: 195880
Coverity-CID: 195816

Fixes #14413
Fixes #14395

Signed-off-by: Jukka Rissanen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jukkar jukkar

Labels
area: Networking area: Tests Issues related to a particular existing or missing test bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jukkar @galak @tedd-an @aasthagr