Skip to content

PyYAML 5.1 breaks DTS parsing #14496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mbolivar opened this issue Mar 13, 2019 · 0 comments · Fixed by #14497
Closed

PyYAML 5.1 breaks DTS parsing #14496

mbolivar opened this issue Mar 13, 2019 · 0 comments · Fixed by #14497
Assignees
@ulfalizer @mike-scott @galak
Labels
bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug

Comments

@mbolivar
Copy link
Contributor

Describe the bug
PyYAML 5.1 was just released, which doesn't support !include as previous versions do. This breaks our DTS bindings parsing. However, fixing to version 3.13 won't work either, as that conflicts with the latest PyOCD.

The real fix seems to be to update our DTS bindings to be 5.1 compliant and update our requirements.txt

To Reproduce
Steps to reproduce the behavior:

  1. Do a fresh Zephyr pip install -r scripts.requirements.txt
  2. Build a sample which uses !include in a DTS binding

Expected behavior
No error

Impact
Parse errors break the build

Environment (please complete the following information):

  • OS: all
  • Toolchain: N/A
  • Commit SHA or Version used: any recent master
@mbolivar mbolivar added the bug The issue is a bug, or the PR is fixing a bug label Mar 13, 2019
@mbolivar mbolivar added the priority: high High impact/importance bug label Mar 13, 2019
@mbolivar mbolivar mentioned this issue Mar 13, 2019
Closed
@mike-scott mike-scott mentioned this issue Mar 13, 2019
Merged
mike-scott added a commit to mike-scott/zephyr that referenced this issue Mar 13, 2019
@mike-scott
scripts/dts: Fix for PyYAML 5.1 Loader changes
36feb6b 
PyYAML 5.1 was just released and it doesn't support !include as
previous versions do.  This breaks our DTS bindings parsing.

Let's fix our extract_dts_include.py script to work with both
3.13 and 5.1.

Also, update the pyyaml requirement to >=3.13 to be sure we're
compatible.

Fixes: zephyrproject-rtos#14496

Signed-off-by: Michael Scott <[email protected]>
galak pushed a commit that referenced this issue Mar 14, 2019
@mike-scott @galak
scripts/dts: Fix for PyYAML 5.1 Loader changes
4278bf5 
PyYAML 5.1 was just released and it doesn't support !include as
previous versions do.  This breaks our DTS bindings parsing.

Let's fix our extract_dts_include.py script to work with both
3.13 and 5.1.

Also, update the pyyaml requirement to >=3.13 to be sure we're
compatible.

Fixes: #14496

Signed-off-by: Michael Scott <[email protected]>
SebastianBoe pushed a commit to nrfconnect/sdk-zephyr that referenced this issue Mar 15, 2019
@mike-scott @SebastianBoe
[nrf fromtree] scripts/dts: Fix for PyYAML 5.1 Loader changes
d701bb6 
PyYAML 5.1 was just released and it doesn't support !include as
previous versions do.  This breaks our DTS bindings parsing.

Let's fix our extract_dts_include.py script to work with both
3.13 and 5.1.

Also, update the pyyaml requirement to >=3.13 to be sure we're
compatible.

Fixes: zephyrproject-rtos/zephyr#14496

Signed-off-by: Michael Scott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ulfalizer ulfalizer

@mike-scott mike-scott

@galak galak

Labels
bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

scripts/dts: Fix for PyYAML 5.1 Loader changes mike-scott/zephyr
4 participants
@mbolivar @ulfalizer @mike-scott @galak