Skip to content

Promiscuous mode net sample cannot be build #14608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
laperie opened this issue Mar 18, 2019 · 1 comment
Closed

Promiscuous mode net sample cannot be build #14608

laperie opened this issue Mar 18, 2019 · 1 comment
Assignees
@jukkar
Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug

Comments

@laperie
Copy link
Collaborator

laperie commented Mar 18, 2019 •
edited
Loading

Describe the bug
The subject says it all ..

To Reproduce
Steps to reproduce the behavior:

  1. cd zephyr/samples/net/promiscuous_mode && mkdir build && cd build
  2. cmake -DBOARD=qemu_x86 ..
  3. make run
  4. See error
    ...
    [ 7%] Building C object CMakeFiles/app.dir/src/main.c.obj
    zephyr/zephyr/samples/net/promiscuous_mode/src/main.c:17:10: fatal error: net/tcp.h: No such file or directory
    #include <net/tcp.h>
    ^~~~~~~~~~~
    compilation terminated.

Expected behavior
Compilation successful

Impact
obvious

Environment (please complete the following information):
Linux/ SDK 0.10.0
@laperie laperie added bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug area: Networking labels Mar 18, 2019
@laperie
Copy link
Collaborator Author

laperie commented Mar 18, 2019 •
edited
Loading

It's also important to ensure this type of failures are caught automatically with this sample

jukkar added a commit to jukkar/zephyr that referenced this issue Mar 18, 2019
@jukkar
samples: net: promisc: Fix compile error
3aa2f4c 
The sample was bitrotted because sample.yaml was missing and no
build checks were done, so we missed the case when TCP header
API function was removed. This is now fixed by using still available
UDP header API (to get the port numbers). Also fixing debug print
as it were giving compile warnings.

Fixes zephyrproject-rtos#14608

Signed-off-by: Jukka Rissanen <[email protected]>
@galak galak closed this as completed in ebce560 Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jukkar jukkar

Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jukkar @laperie