Skip to content

[Coverity CID :196639]Error handling issues in /samples/bluetooth/ipsp/src/main.c #14817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aasthagr opened this issue Mar 22, 2019 · 1 comment
Closed

[Coverity CID :196639]Error handling issues in /samples/bluetooth/ipsp/src/main.c #14817

aasthagr opened this issue Mar 22, 2019 · 1 comment
Assignees
@tbursztyka @Vudentz
Labels
area: Samples Samples bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix

Comments

@aasthagr
Copy link
Collaborator

Static code scan issues seen in File: /samples/bluetooth/ipsp/src/main.c
Category: Error handling issues
Function: build_reply
Component: Samples
CID: 196639
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996
@aasthagr aasthagr added area: Samples Samples bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix labels Mar 22, 2019
@Vudentz
Copy link
Collaborator

Vudentz commented Mar 22, 2019

@tbursztyka Im fixing it

Vudentz added a commit to Vudentz/zephyr that referenced this issue Mar 22, 2019
@Vudentz
Bluetooth: samples: IPSP: Fix not checking return of net_pkt_read
7d3b0b8 
net_pkt_read may fail in which case the error shall be reported back
instead of always assuming the whole packet was read.

Fixes zephyrproject-rtos#14817

Signed-off-by: Luiz Augusto von Dentz <[email protected]>
@Vudentz Vudentz mentioned this issue Mar 22, 2019
Merged
jhedberg pushed a commit that referenced this issue Mar 22, 2019
@Vudentz @jhedberg
Bluetooth: samples: IPSP: Fix not checking return of net_pkt_read
ef9c7a4 
net_pkt_read may fail in which case the error shall be reported back
instead of always assuming the whole packet was read.

Fixes #14817

Signed-off-by: Luiz Augusto von Dentz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbursztyka tbursztyka

@Vudentz Vudentz

Labels
area: Samples Samples bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tbursztyka @Vudentz @aasthagr