Skip to content

Cannot build samples/net/ipv4_autoconf #15096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pfl opened this issue Apr 1, 2019 · 6 comments
Closed

Cannot build samples/net/ipv4_autoconf #15096

pfl opened this issue Apr 1, 2019 · 6 comments
Assignees
@rveerama1
Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Milestone
v1.14.0

Comments

@pfl
Copy link
Collaborator

pfl commented Apr 1, 2019

Building samples/net/ipv4_autoconf for sam_e70_explained fails with errors. Upstream is at 1eead93.

$ cd samples/net/ipv4_autoconf
$ make build && cd build
$ cmake -GNinja -DBOARD=sam_e70_xplained ..
$ ninja

...

zephyr/drivers/ethernet/eth_sam_gmac.c:60:2: error: #error Remaining free RX data buffers (CONFIG_NET_BUF_RX_COUNT -
 #error Remaining free RX data buffers (CONFIG_NET_BUF_RX_COUNT -
  ^~~~~
In file included from <command-line>:
zephyr/samples/net/ipv4_autoconf/build/zephyr/include/generated/autoconf.h:138:42: error: expected identifier or '(' before numeric constant
 #define CONFIG_ETH_SAM_GMAC_BUF_RX_COUNT 12
                                          ^~
zephyr/drivers/ethernet/eth_sam_gmac.c:61:2: note: in expansion of macro 'CONFIG_ETH_SAM_GMAC_BUF_RX_COUNT'
  CONFIG_ETH_SAM_GMAC_BUF_RX_COUNT) * CONFIG_NET_BUF_DATA_SIZE
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
zephyr/drivers/ethernet/eth_sam_gmac.c:1982:12: error: 'rx_desc_que0' undeclared here (not in a function); did you mean 'tx_desc_que0'?
     .buf = rx_desc_que0,
            ^~~~~~~~~~~~
            tx_desc_que0
[68/143] Building C object zephyr/arch/arch/arm/core/cortex_m/CMakeFiles/arch__arm__core__cortex_m.dir/exc_manage.c.obj
@pfl pfl added the bug The issue is a bug, or the PR is fixing a bug label Apr 1, 2019
@nashif nashif added area: Networking priority: low Low impact/importance bug labels Apr 1, 2019
@rveerama1 rveerama1 assigned rveerama1 and unassigned jukkar Apr 3, 2019
rveerama1 added a commit to rveerama1/zephyr that referenced this issue Apr 3, 2019
@rveerama1
drivers: sam_gmac: Fix compilation warning
b56775b 
Line continuation was missing for #error macro.

Fixes  zephyrproject-rtos#15096

Signed-off-by: Ravi kumar Veeramally <[email protected]>
@rveerama1 rveerama1 mentioned this issue Apr 3, 2019
Merged
@rveerama1
Copy link
Collaborator

@pfl PR provided and given explanation there. Please take a look.

@jukkar jukkar added this to the v1.14.0 milestone Apr 3, 2019
nashif pushed a commit that referenced this issue Apr 3, 2019
@rveerama1 @nashif
drivers: sam_gmac: Fix compilation warning
ecdef39 
Line continuation was missing for #error macro.

Fixes  #15096

Signed-off-by: Ravi kumar Veeramally <[email protected]>
@pfl pfl reopened this Apr 3, 2019
@pfl
Copy link
Collaborator Author

pfl commented Apr 3, 2019

Still failing with:

zephyr/drivers/ethernet/eth_sam_gmac.c:60:2: error: #error (CONFIG_NET_BUF_RX_COUNT - CONFIG_ETH_SAM_GMAC_BUF_RX_COUNT) * CONFIG_NET_BUF_DATA_SIZE are not large enough to hold a full frame
 #error (CONFIG_NET_BUF_RX_COUNT - CONFIG_ETH_SAM_GMAC_BUF_RX_COUNT) * \
  ^~~~~
[58/150] Building C object zephyr/arch/arch/arm/core/CMakeFiles/arch__arm__core.dir/swap.c.obj

@rveerama1
Copy link
Collaborator

rveerama1 commented Apr 4, 2019 •
edited
Loading

I already mentioned this in PR.

But it still gives error when you compile samples/net/ipv4_autoconf sample for sam_e70_xplained board. Its because of low RX buffer count in prj.conf. If someone wants to build this sample please increase the Rx Buffer count.

@pfl
Copy link
Collaborator Author

pfl commented Apr 4, 2019 •
edited
Loading

please increase the Rx Buffer count.

Shouldn't that be "the bug" for sam_e70_xplained in this sample then? Why is the prj.conf left in such a low buffer count state in the first place? How do I know what the necessary minimum buffer count is?

@pfl
Copy link
Collaborator Author

pfl commented Apr 4, 2019

Can we have a .prj file for sam_e70_xplained to get this sample working out of the box?

@pfl pfl reopened this Apr 4, 2019
@rveerama1 rveerama1 mentioned this issue Apr 5, 2019
Merged
@rveerama1
Copy link
Collaborator

@pfl submitted fix.

rveerama1 added a commit to rveerama1/zephyr that referenced this issue Apr 5, 2019
@rveerama1
net: samples: ipv4_autoconf: Need more buffers for same_70
eac1f51 
More buffers are need to build for sam_e70_xplained board
to work out of the box. Added board specific conf file.

Fixes zephyrproject-rtos#15096

Signed-off-by: Ravi kumar Veeramally <[email protected]>
andrewboie pushed a commit to andrewboie/zephyr that referenced this issue Apr 5, 2019
@rveerama1 @nashif
net: samples: ipv4_autoconf: Need more buffers for same_70
06159d3 
More buffers are need to build for sam_e70_xplained board
to work out of the box. Added board specific conf file.

Fixes zephyrproject-rtos#15096

Signed-off-by: Ravi kumar Veeramally <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rveerama1 rveerama1

Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
v1.14.0
Development

No branches or pull requests
4 participants
@nashif @pfl @jukkar @rveerama1