Skip to content

[Coverity CID :187325] Control flow issues in /samples/boards/nrf52/mesh/onoff_level_lighting_vnd_app/src/mesh/device_composition.c #9290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mandarcthorat1 opened this issue Aug 4, 2018 · 1 comment
Closed

[Coverity CID :187325] Control flow issues in /samples/boards/nrf52/mesh/onoff_level_lighting_vnd_app/src/mesh/device_composition.c #9290

mandarcthorat1 opened this issue Aug 4, 2018 · 1 comment
Assignees
@jhedberg
Labels
area: Samples Samples bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug

Comments

@mandarcthorat1
Copy link
Contributor

Static code scan issues seen in File: /samples/boards/nrf52/mesh/onoff_level_lighting_vnd_app/src/mesh/device_composition.c
Category: Control flow issues
Function: light_ctl_temp_range_set_unack
Component: Samples
CID: 187325
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996
@mandarcthorat1 mandarcthorat1 added area: Samples Samples bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix labels Aug 4, 2018
subbu147 added a commit to subbu147/zephyr that referenced this issue Aug 6, 2018
@subbu147
samples: boards: Fix incorrect min max range validation
ff0870d 
Fixing the min max range validation where condtions on
upper and lower bound are logically 'ANDed'. Fixing it
by logical ORing the result.

CID: 18325, 18326
Fixes Issue zephyrproject-rtos#9289
Fixes Issue zephyrproject-rtos#9290

Signed-off-by: Subramanian Meenakshi Sundaram <[email protected]>
@subbu147 subbu147 mentioned this issue Aug 6, 2018
Merged
nashif pushed a commit that referenced this issue Aug 14, 2018
@subbu147 @nashif
samples: boards: Fix incorrect min max range validation
df20ebd 
Fixing the min max range validation where condtions on
upper and lower bound are logically 'ANDed'. Fixing it
by logical ORing the result.

CID: 18325, 18326
Fixes Issue #9289
Fixes Issue #9290

Signed-off-by: Subramanian Meenakshi Sundaram <[email protected]>
@nashif nashif added the priority: low Low impact/importance bug label Aug 14, 2018
@nashif
Copy link
Member

nashif commented Mar 5, 2019

not current in coverity anymore and marked fixed.

@nashif nashif closed this as completed Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhedberg jhedberg

Labels
area: Samples Samples bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nashif @jhedberg @mandarcthorat1